Code review comment for lp:~macslow/notify-osd/conditional-bubble-refresh

Revision history for this message
Ted Gould (ted) wrote :

I don't understand why you're only comparing the basename of the icons. It seems like there could be an odd case where there is the same basename, but different paths to an icon. It seems like you already have the path, just use that.

Everything else looks good.

review: Needs Information

« Back to merge proposal