Merge lp:~maco.m/ubiquity/bug749653 into lp:ubiquity

Proposed by Mackenzie Morgan
Status: Merged
Merged at revision: 4694
Proposed branch: lp:~maco.m/ubiquity/bug749653
Merge into: lp:ubiquity
Diff against target: 58 lines (+30/-0) (has conflicts)
2 files modified
debian/changelog (+8/-0)
ubiquity/plugins/ubi-partman.py (+22/-0)
Text conflict in debian/changelog
To merge this branch: bzr merge lp:~maco.m/ubiquity/bug749653
Reviewer Review Type Date Requested Status
Colin Watson Pending
Review via email: mp+57772@code.launchpad.net

Description of the change

Make the partitioning page more screen-reader-friendly by linking the radio buttons and labels together. Result is the label is read out loud.

Unfortunately, the variable name is still read, but since this means the "there's no information about what happens" problem (that makes it High importance) is fixed, I think the papercut of it still saying the variable name can be ignored.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-04-13 18:25:33 +0000
3+++ debian/changelog 2011-04-14 20:53:58 +0000
4@@ -94,6 +94,7 @@
5 [ Colin Watson ]
6 * Switch to xz compression for the source package, saving nearly a
7 megabyte.
8+<<<<<<< TREE
9 * Update translations from Launchpad.
10 * Update imported translations from gtk+2.0 2.24.4-0ubuntu1.
11 * Automatic update of included source packages: apt-setup 1:0.49ubuntu4,
12@@ -103,6 +104,13 @@
13 * Update artwork gui/qt/images/squares.png
14
15 -- Colin Watson <cjwatson@ubuntu.com> Sun, 10 Apr 2011 01:47:19 +0100
16+=======
17+
18+ [ Mackenzie Morgan ]
19+ * Make radio buttons use label wording for screen reader (LP: #749653)
20+
21+ -- Mackenzie Morgan <maco.m@ubuntu.com> Thu, 07 Apr 2011 00:02:21 -0400
22+>>>>>>> MERGE-SOURCE
23
24 ubiquity (2.5.34) natty; urgency=low
25
26
27=== modified file 'ubiquity/plugins/ubi-partman.py'
28--- ubiquity/plugins/ubi-partman.py 2011-04-13 12:53:25 +0000
29+++ ubiquity/plugins/ubi-partman.py 2011-04-14 20:53:58 +0000
30@@ -125,6 +125,28 @@
31 self.custom_partitioning_title = builder.get_object('custom_partitioning_title')
32 self.custom_partitioning_desc = builder.get_object('custom_partitioning_desc')
33
34+ # Ask page accessibility
35+ self.atk_use_device = self.use_device.get_accessible()
36+ self.atk_use_device_title = self.use_device_title.get_accessible()
37+ self.atk_use_device_title.add_relationship(atk.RELATION_LABEL_FOR, self.atk_use_device)
38+ self.atk_use_device.add_relationship(atk.RELATION_LABELLED_BY, self.atk_use_device_title)
39+ self.atk_replace_partition = self.replace_partition.get_accessible()
40+ self.atk_replace_partition_title = self.replace_partition_title.get_accessible()
41+ self.atk_replace_partition_title.add_relationship(atk.RELATION_LABEL_FOR, self.atk_replace_partition)
42+ self.atk_replace_partition.add_relationship(atk.RELATION_LABELLED_BY, self.atk_replace_partition_title)
43+ self.atk_reuse_partition = self.reuse_partition.get_accessible()
44+ self.atk_reuse_partition_title = self.reuse_partition_title.get_accessible()
45+ self.atk_reuse_partition_title.add_relationship(atk.RELATION_LABEL_FOR, self.atk_reuse_partition)
46+ self.atk_reuse_partition.add_relationship(atk.RELATION_LABELLED_BY, self.atk_reuse_partition_title)
47+ self.atk_resize_use_free = self.resize_use_free.get_accessible()
48+ self.atk_resize_use_free_title = self.resize_use_free_title.get_accessible()
49+ self.atk_resize_use_free_title.add_relationship(atk.RELATION_LABEL_FOR, self.atk_resize_use_free)
50+ self.atk_resize_use_free.add_relationship(atk.RELATION_LABELLED_BY, self.atk_resize_use_free_title)
51+ self.atk_custom_partitioning = self.custom_partitioning.get_accessible()
52+ self.atk_custom_partitioning_title = self.custom_partitioning_title.get_accessible()
53+ self.atk_custom_partitioning_title.add_relationship(atk.RELATION_LABEL_FOR, self.atk_custom_partitioning)
54+ self.atk_custom_partitioning.add_relationship(atk.RELATION_LABELLED_BY, self.atk_custom_partitioning_title)
55+
56 # Advanced page
57 self.partition_create_mount_combo = builder.get_object('partition_create_mount_combo')
58 self.partition_edit_mount_combo = builder.get_object('partition_edit_mount_combo')

Subscribers

People subscribed via source and target branches

to status/vote changes: