Merge lp:~maclin.jun/ubiquity/ubiquity into lp:ubiquity

Proposed by Ma Jun
Status: Rejected
Rejected by: Dimitri John Ledkov
Proposed branch: lp:~maclin.jun/ubiquity/ubiquity
Merge into: lp:ubiquity
Diff against target: 12 lines (+1/-1)
1 file modified
bin/ubiquity-dm (+1/-1)
To merge this branch: bzr merge lp:~maclin.jun/ubiquity/ubiquity
Reviewer Review Type Date Requested Status
Colin Watson (community) Disapprove
Review via email: mp+189496@code.launchpad.net

Description of the change

change the ubuntukylin backgroud wallpaper name in ubiquity-dm from "ubuntukylin-default-settings.jpg" to "warty-final-ubuntukylin.jpg". This change is done according to name rules of ubuntu.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

As discussed on IRC, I think this is a mistake; "warty-final-ubuntu.png" is a historical mistake in Ubuntu that there should be no reason to imitate in other flavours. "ubuntukylin-default-settings.png" is actually a better name. If it's feasible for you to revert the other changes associated with this rather than changing ubiquity, I think that would be better.

review: Disapprove
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Trusty now simply looks up wallpaper from gsettings, no need to hard-code names when one is using gnome-settings-daemon.

Unmerged revisions

6007. By Ma Jun

change backgroud wallpaper name according to name rules in ubiquity-dm

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/ubiquity-dm'
2--- bin/ubiquity-dm 2013-09-25 12:18:25 +0000
3+++ bin/ubiquity-dm 2013-10-06 09:57:53 +0000
4@@ -351,7 +351,7 @@
5 '/usr/share/xfce4/backdrops/xubuntu-wallpaper.png',
6 '/usr/share/lubuntu/wallpapers/'
7 'lubuntu-default-wallpaper.png',
8- '/usr/share/backgrounds/ubuntukylin-default-settings.jpg',
9+ '/usr/share/backgrounds/warty-final-ubuntukylin.jpg',
10 '/usr/share/backgrounds/warty-final-ubuntu.png',
11 '/usr/share/backgrounds/gnome/FootFall.png'):
12 exists = os.access(background, os.R_OK)

Subscribers

People subscribed via source and target branches

to status/vote changes: