Code review comment for lp:~mabac/svammel/bug-749561-set-series-and-milestone

> 53 + set_bugtask_milestone(ms_bugtask, milestone)
>
> I would probably add a check here whether the bugtask was found, asking them
> to
> report a bug if not, otherwise they will get a confusing error.

Good idea, I have added that.

> > Another piece of the puzzle is that the user might be able to add a
> nomination but is not allowed to
> > approve it. The new bugtask is only created when the nomination is approved.
>
> I think an error if they request an impossible situation is fine. Wouldn't the
> --continue-on-error
> support deal with that anyway if they wanted?

Yes it would. I changed it a bit so now series nomination can fail in a couple of ways and still try to set milestone if --ignore-errors is passed.

>
> As it stands though I don't think it will continue if the person can't do it,
> as the code
> for finding the task now assumes that a series task will be created if
> --series is specified.
>
> Perhaps it should not assume that and then decide what to do based on
> --continue-on-error?

Now it doesn't assume that and will set milestone even if the user has no permissions for targeting series.

I'll merge this in the morning if no-one comments on the last revisions.

Thanks,

Mattias