Code review comment for lp:~mabac/svammel/bug-749560-dont-hardcode-arch-tags

On Wed, 06 Apr 2011 12:46:37 -0000, Mattias Backman <email address hidden> wrote:
> Yeah, I thought that having the original tags as default would be less
> intrusive to Steve at the moment. To make the script really generic I
> think that there should be no default tags or
> architectures. Specifying no tags should mean to not set tags and the
> arch options should be required. As implemented now, it's still an arm
> bug filer with the option to override that.

Yeah, I think that's ok reasoning.

>
> > Secondly, could you use a default argument to the Option creation, rather
> > than using the conditionals later?
>
> I tried to do that. Having a default for an 'append' type option made
> the specified tag be appended to the default list. I would have wanted
> the default list only when no --bugtag was specified.

That's unexpected. I'm happy with what you've done then.

Thanks,

James