Code review comment for lp:~mabac/svammel/bug-749560-dont-hardcode-arch-tags

Revision history for this message
Mattias Backman (mabac) wrote :

> Two minor points. It's not possible to have no tags on the bugs with this
> scheme, but I don't think that's a great loss.

Yeah, I thought that having the original tags as default would be less intrusive to Steve at the moment. To make the script really generic I think that there should be no default tags or architectures. Specifying no tags should mean to not set tags and the arch options should be required. As implemented now, it's still an arm bug filer with the option to override that.

> Secondly, could you use a default argument to the Option creation, rather
> than using the conditionals later?

I tried to do that. Having a default for an 'append' type option made the specified tag be appended to the default list. I would have wanted the default list only when no --bugtag was specified.

It would be possible for the --target-arch option though since that's not appending to a list, but then I'd have different handling of defaults for the two arch options.

Thanks,

Mattias

« Back to merge proposal