Code review comment for lp:~mabac/svammel/auto-close-retried

On Tue, Mar 29, 2011 at 08:58:29AM -0000, Mattias Backman wrote:
> > More importantly, we should only be closing bug tasks corresponding to the
> > package the bug was originally reported on. If a bug report gets addressed in
> > the current package by applying a workaround, but a new task has been opened
> > on, for example, gcc-linaro to flag that the compiler needs a fix for the
> > underlying issue, we shouldn't touch that task.

> Thanks for clarifying, I'll fix that.

> Closing bugs is only done when a later successful build on armel is found.
> I do not check for later failures on the other archs. This means that if
> we run the script on partially built archives where the armel build has
> failed and the builds are not yet started on the other archs there will be
> a bug that's not going to be closed even if the other builds fail. Will
> this be a problem?

No, I think that's fine as the x86 rebuild is obviously going to run much
faster than the armel one in the general case, and we would want to avoid
filing bugs where we know we don't have enough information yet to say if
they're cross-platform. But please document this limitation.

Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
<email address hidden> <email address hidden>