Code review comment for lp:~mabac/svammel/auto-close-retried

Revision history for this message
James Westby (james-w) wrote :

24 + for bug_task in bug.bug_tasks:
25 + print_message(" Changing status for %s [%s ==> %s]" % \
26 + (bug_task.title, bug_task.status, BUG_CLOSED_STATUS))

Perhaps we should have the --dry-run support here too?

Ah, I see now it is done at a higher level, but that message
doesn't say what bug would be closed. Could we have it print
the ".web_link" of each task that would be closed?

I have no problems with the code, it looks good to me.

I do wonder about whether this should be a separate script (--force-close
can be), but I wonder if just having the script in cron clean up
automatically would be better. Or would you imagine having both scripts
in cron?

Also, closing bugs doesn't alter the log file, will that lead to
missing bugs if it goes fail->success->fail?

Thanks,

James

« Back to merge proposal