Code review comment for lp:~mabac/linaro-image-tools/snowball-support

Revision history for this message
Hans Odeberg (hans-odeberg) wrote :

> Branch looks good to me; since you removed the sample toc file and since I
> don't think we have support in linaro-hwpack-create for TOCs, I would suggest
> you add some explanation under doc/ on how the toc file and on repacking
> hwpacks with such a file; e.g. a doc/snowball-emmc-hwpacks.txt or something
> like that which would say something like:
> ===
> hwpacks for use with --dev snowball-emmc need a file called toc.cfg at the
> root of the tarball, but this isn't yet supported by linaro-hwpack-create;
> repack the hwpack by unpacking the tarball, adding the toc file and the files
> it references at the root of the tarball and repack the tarball. The TOC file
> has this format:
> <sample TOC file>
> ===
>
> or file a bug to remind ourselves about this lack of support for toc files in
> linaro-hwpack-create or lack of documentation on working around it

Do we need to add support for toc files in linaro-hwpack-create? The fewer Snowball-specific changes, the better. I would prefer if the toc file was simply just another Snowball-specific file packaged inside a deb-package in the hw pack, just the way other files are packaged. Then linaro-media-create just unpacks the hw pack, and the file ends up in the /boot directory. Could this work?

« Back to merge proposal