Code review comment for lp:~mabac/linaro-image-tools/snowball-support

Revision history for this message
Hans Odeberg (hans-odeberg) wrote :

Looks good to me, so far (with the limitations on tests and sanity checks you mentioned above).

Just a question on SNOWBALL_STARTUP_FILES_CONFIG. Right now, it identifies a file in the lmc install directory, and the patch also contains such a file. Do you want the file to be there for now, removing it when the file is included in a hwpack?

« Back to merge proposal