Code review comment for lp:~mabac/linaro-image-tools/scripts-hooks

On Wed, Jan 25, 2012 at 6:31 PM, Ricardo Salveti <email address hidden> wrote:
> On Wed, Jan 25, 2012 at 6:35 AM, Mattias Backman
> <email address hidden> wrote:
>>> Tested with 2 simple scripts and it worked well.
>>>
>>> A few comments:
>>> 1. At the preinstall script there's no way to access the hwpack content,
>>> because it wasn't yet extracted. This may be useful for people that want to
>>> read from hwpack packages or even customize in some way.
>>
>> Would you like the pre-hooks to be run in linaro-hwpack-install instead? That way the script can be run for every hwpack after unpacking it, meaning the pre-hook is run once per hwpack. If you mean we should unpack all the hwpacks and then run the pre-hook once it will require some more work but it is possible of course.
>
> Can you flash the image using more than one hwpack? I thought it'd use
> just one hwpack :-)

You can give as many hwpacks to l-m-c as you like, but most hwpacks
won't make any sense to combine of course. It's intended for having
base and addon hwpacks I think, but I'm not sure it's the most used
feature of l-m-c.

>
> Guess to simplify things having the pre-hook the way you implemented
> should be fine for now.
>
> --
> https://code.launchpad.net/~mabac/linaro-image-tools/scripts-hooks/+merge/89889
> You are the owner of lp:~mabac/linaro-image-tools/scripts-hooks.