Code review comment for lp:~mabac/linaro-image-tools/make-boot-files-v2

171 + make_uImage(cls.load_addr, k_img_data, boot_dir)
172 + make_uInitrd(i_img_data, boot_dir)
173 +
174 + if d_img_data is not None:

The comment doesn't show it, but the indentation seems off there.

Also, it would be good to extract some more code to avoid
duplication (such as the samsung offset assertions.)

We don't want to duplicate all this code, but at the same time
we want it to be clear that changing this isn't the way
to support software changes.

Lastly, but not directly related to this change, I wonder if
the meaning of all these config options are going to be clear
to everyone? Will they need some documentation of what the
effects are so they know what to set for their board?

Thanks,

James