Code review comment for lp:~mabac/linaro-image-tools/hwpacks-v2-lmc

Revision history for this message
James Westby (james-w) wrote :

56 + "section. Valid partition layouts are bootfs16_rootfs, " \
57 + "bootfs_rootfs.", config)

Could we make that exception text use the defined_partition_layouts so that it
is never out of date?

160 + assert format == format_string, "Mixing hwpack formats is " \
161 + "not supported!"

Is there a particular reason for that?

This looks good to me though.

Thanks,

James

review: Approve

« Back to merge proposal