Code review comment for lp:~mabac/linaro-image-tools/hwpacks-v2-lmc
Revision history for this message
| Mattias Backman (mabac) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Hi,
>
> This is pretty small, nice work.
>
> I wonder if using ConfigParser to read the metadata file will do something
> odd to the data in some circumstances? Perhaps we should turn off all its
> magic?
I don't know what magic changes it might do to the data. Is there some type of common conversions that it does? If there's any risk of strange bugs in the future, it might be better to simply tokenize the metadata file at '=' or something.
>
> As for multiple hwpacks, I think it should set with data from all of them
> eventually, only using the data where defined, and erroring on overlaps. For
> now I think just finding the hwpack with the metadata that we want is good
> enough (only one will include a kernel.)
Then I'll go with setting the data from all hwpacks and fail if the same field is set more than once.