Code review comment for lp:~mabac/linaro-image-tools/bug-638384-hwpackforceyes-unneeded
Revision history for this message
| Mattias Backman (mabac) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
On Fri, Apr 29, 2011 at 7:51 PM, Guilherme Salgado
<email address hidden> wrote:
> The existing code seems to cause the script to abort when the sha1sum check of any hwpack fails, but after this change I think such a failure wouldn't cause the script to abort. Is this intentional?
I think that cmd_runner makes the script abort when the return code of
sha1sums is > 0. So I think that I can remove the check from the call
to gpg also since it aborts anyway. I couldn't decide whether to do
that or leave it in to make it clear that the intention is to abort
when the verification fails. But then I should do something similar
for sha1sums to be consistent, I guess.