Code review comment for lp:~mabac/launchpad-work-items-tracker/move-card-healh-check

Revision history for this message
Mattias Backman (mabac) wrote :

> review approve
>
> On Fri, 2011-12-09 at 10:44 +0000, Mattias Backman wrote:
> [...]
> > === modified file 'templates/roadmap_card.html'
> > --- templates/roadmap_card.html 2011-11-30 20:38:49 +0000
> > +++ templates/roadmap_card.html 2011-12-09 10:43:21 +0000
> > @@ -11,6 +11,18 @@
> > </%def>
> >
> > <h1>${title()}</h1>
> > +<div style="float: right">
> > +<h3>Health check</h3>
> > +
> > +<table>${'<tr colspan="2"><td><font color="#FF0000"><b>Needs
> attention!</b></font></td></tr>' if not card.is_healthy else ''}
> > + % for result in health_checks:
> > + <tr ${'bgcolor="#FFAAAA"' if result['result'] == 'Not OK' else
> 'bgcolor="#FFFFFF"'}>
> > + <td>${result['name']}</td>
> > + <td>${result['result']}</td>
> > +</tr>
> > +% endfor
>
> The indentation of the two lines above is off by 2 levels and 1 level
> respectively. Care to fix it? :)

Absolutely, thanks for catching that too!

>
> > +</table>
> > +</div>

« Back to merge proposal