Code review comment for lp:~mabac/launchpad-work-items-tracker/linaro-roadmap-tracker

On Mon, Sep 12, 2011 at 9:29 PM, James Westby <email address hidden> wrote:
> Review: Approve
>
> 246     +for lane in report_tools.lanes(store):
>
> I don't think we need to query again there, we can just use the "lanes"
> variable that was used in the previous call.

Fixed. It was the first call that could go away.

>
> This looks good, assuming that it will cope with there being no
> lanes in the db for a while. (The pages aren't linked, so it's fine
> if they are empty or missing or whatever, but it can't crash if there
> are no lanes.)

I think it'll be fine, as long as the new tables are in the db. If the
Lanes table is empty, the roadmap.html will contain only the heading
and the other pages will not be created.