Code review comment for lp:~mabac/launchpad-work-items-tracker/linaro-roadmap-layout-fixes

Revision history for this message
Mattias Backman (mabac) wrote :

On Wed, Nov 30, 2011 at 9:15 PM, Guilherme Salgado
<email address hidden> wrote:
> Review: Needs Information
>
> Wow, it felt like I was reviewing PHP with all this code included within the html. ;)

Hehe sorry about that. I'm not too happy with the results when trying
to do smart things in the templates. I have pushed an update to make
it a little less cluttered.

>
> I suppose blueprints.itervalues() would return a sequence of lists (or other sequences) and there's no way a None can end up there, right?

Famous last words: nope, that shouldn't happen. :) They're all
initialized to [] in report_tools.card_blueprints_by_status().

> --
> https://code.launchpad.net/~mabac/launchpad-work-items-tracker/linaro-roadmap-layout-fixes/+merge/83903
> You are the owner of lp:~mabac/launchpad-work-items-tracker/linaro-roadmap-layout-fixes.

« Back to merge proposal