Merge lp:~mabac/launchpad-work-items-tracker/linaro-roadmap-frontpage into lp:launchpad-work-items-tracker

Proposed by Mattias Backman
Status: Superseded
Proposed branch: lp:~mabac/launchpad-work-items-tracker/linaro-roadmap-frontpage
Merge into: lp:launchpad-work-items-tracker
Prerequisite: lp:~mabac/launchpad-work-items-tracker/linaro-roadmap-add-priority
Diff against target: 122 lines (+20/-9) (has conflicts)
6 files modified
collect_roadmap (+4/-0)
generate-all (+0/-5)
html-report (+3/-1)
lpworkitems/database.py (+2/-0)
lpworkitems/models_roadmap.py (+2/-1)
templates/roadmap_lane.html (+9/-2)
Text conflict in generate-all
Text conflict in report_tools.py
To merge this branch: bzr merge lp:~mabac/launchpad-work-items-tracker/linaro-roadmap-frontpage
Reviewer Review Type Date Requested Status
James Westby (community) Approve
Review via email: mp+79839@code.launchpad.net

This proposal has been superseded by a proposal from 2011-10-20.

Description of the change

Hi,

This branch removes the roadmap.html front page and adds a drop down selector on the lane view pages.

Also make the cards in the lanes view equal width by setting all of them to occupy 45% screen width.

Thanks,

Mattias

To post a comment you must log in.
Revision history for this message
James Westby (james-w) :
review: Approve

Unmerged revisions

308. By Mattias Backman

Make the current lane default in the selection dropdown.

307. By Mattias Backman

Make all card equal width in lane view.

306. By Mattias Backman

Put a lane selector on top of the Lane views.

305. By Mattias Backman

Don't generate roadmap.html.

304. By Mattias Backman

Mark lane as current based on name.

303. By Mattias Backman

Merge get-priority.

302. By Mattias Backman

Add is_current to Lane.

301. By Mattias Backman

Ignore the Legend and Deferred lanes as well as Summits cards. Also change the board id.

300. By Mattias Backman

Add Roadmap cards to Linaro roadmap reporting.

299. By Mattias Backman

Use the same lock for collect_roadmap as is used for collect.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'collect_roadmap'
--- collect_roadmap 2011-10-19 15:17:01 +0000
+++ collect_roadmap 2011-10-19 15:17:02 +0000
@@ -75,6 +75,10 @@
75 assert node['parent_id'] == root_node_id75 assert node['parent_id'] == root_node_id
76 model_lane = Lane(unicode_or_None(node['name']),76 model_lane = Lane(unicode_or_None(node['name']),
77 node['id'])77 node['id'])
78 if model_lane.name == '2011Q3':
79 model_lane.is_current = True
80 else:
81 model_lane.is_current = False
78 collector.store_lane(model_lane)82 collector.store_lane(model_lane)
79 node_id = node['id']83 node_id = node['id']
80 if node_id in nodes:84 if node_id in nodes:
8185
=== modified file 'generate-all'
--- generate-all 2011-10-19 15:17:01 +0000
+++ generate-all 2011-10-19 15:17:02 +0000
@@ -170,11 +170,6 @@
170basename = os.path.join(opts.output_dir, 'index')170basename = os.path.join(opts.output_dir, 'index')
171report_tools.status_overview(my_path, opts.database, basename, opts.config, root=opts.root)171report_tools.status_overview(my_path, opts.database, basename, opts.config, root=opts.root)
172172
173# roadmap overview
174basename = os.path.join(opts.output_dir, 'roadmap')
175report_tools.roadmap_overview(my_path, opts.database, basename, opts.config,
176 root=opts.root)
177
178# roadmap lanes173# roadmap lanes
179for lane in report_tools.lanes(store):174for lane in report_tools.lanes(store):
180 basename = os.path.join(opts.output_dir, 'roadmap-' + lane.name)175 basename = os.path.join(opts.output_dir, 'roadmap-' + lane.name)
181176
=== modified file 'html-report'
--- html-report 2011-10-19 15:17:01 +0000
+++ html-report 2011-10-19 15:17:02 +0000
@@ -478,13 +478,15 @@
478478
479 data = self.template_data(store, opts)479 data = self.template_data(store, opts)
480 lane = report_tools.lane(store, opts.lane).one()480 lane = report_tools.lane(store, opts.lane).one()
481 lanes = report_tools.lanes(store)
481 statuses = []482 statuses = []
482 for status, cards in report_tools.statuses(store, lane):483 for status, cards in report_tools.statuses(store, lane):
483 statuses.append(dict(name=status, cards=cards))484 statuses.append(dict(name=status, cards=cards))
484 485
485 data.update(dict(statuses=statuses))486 data.update(dict(statuses=statuses))
486 data.update(dict(page_type="roadmap_lane"))487 data.update(dict(page_type="roadmap_lane"))
487 data.update(dict(lane=title))488 data.update(dict(lane_title=title))
489 data.update(dict(lanes=lanes))
488 print report_tools.fill_template(490 print report_tools.fill_template(
489 "roadmap_lane.html", data, theme=opts.theme)491 "roadmap_lane.html", data, theme=opts.theme)
490492
491493
=== modified file 'lpworkitems/database.py'
--- lpworkitems/database.py 2011-10-19 15:17:01 +0000
+++ lpworkitems/database.py 2011-10-19 15:17:02 +0000
@@ -93,6 +93,7 @@
93 store.execute('''CREATE TABLE lane (93 store.execute('''CREATE TABLE lane (
94 name VARCHAR(200) NOT NULL,94 name VARCHAR(200) NOT NULL,
95 lane_id NOT NULL,95 lane_id NOT NULL,
96 is_current BOOLEAN,
96 cards REFERENCES card(card_id)97 cards REFERENCES card(card_id)
97 )''')98 )''')
9899
@@ -225,6 +226,7 @@
225 store.execute('ALTER TABLE card ADD COLUMN contact VARCHAR(50)')226 store.execute('ALTER TABLE card ADD COLUMN contact VARCHAR(50)')
226 store.execute('ALTER TABLE card ADD COLUMN description BLOB')227 store.execute('ALTER TABLE card ADD COLUMN description BLOB')
227 store.execute('ALTER TABLE card ADD COLUMN acceptance_criteria BLOB')228 store.execute('ALTER TABLE card ADD COLUMN acceptance_criteria BLOB')
229 store.execute('ALTER TABLE lane ADD COLUMN is_current BOOLEAN')
228 store.execute('UPDATE version SET db_layout_ref = 13')230 store.execute('UPDATE version SET db_layout_ref = 13')
229231
230232
231233
=== modified file 'lpworkitems/models_roadmap.py'
--- lpworkitems/models_roadmap.py 2011-10-19 15:17:01 +0000
+++ lpworkitems/models_roadmap.py 2011-10-19 15:17:02 +0000
@@ -2,7 +2,7 @@
2import re2import re
3from utils import unicode_or_None3from utils import unicode_or_None
44
5from storm.locals import Date, Reference, ReferenceSet, Unicode, Int5from storm.locals import Date, Reference, ReferenceSet, Unicode, Int, Bool
66
77
8class Card(object):8class Card(object):
@@ -35,6 +35,7 @@
3535
36 name = Unicode()36 name = Unicode()
37 lane_id = Int(primary=True)37 lane_id = Int(primary=True)
38 is_current = Bool()
38 cards = ReferenceSet(lane_id, Card.lane_id)39 cards = ReferenceSet(lane_id, Card.lane_id)
3940
40 def __init__(self, name, lane_id):41 def __init__(self, name, lane_id):
4142
=== modified file 'templates/roadmap_lane.html'
--- templates/roadmap_lane.html 2011-10-19 15:17:01 +0000
+++ templates/roadmap_lane.html 2011-10-19 15:17:02 +0000
@@ -6,8 +6,15 @@
6import report_tools6import report_tools
7%>7%>
88
9Lane to view:
10<select name="laneselect" onchange="window.location=this.value;">
11% for lane in lanes:
12<option value="roadmap-${lane.name}.html"${' selected="selected"' if lane.name == lane_title else ''}>${lane.name}${' (current)' if lane.is_current else ''}</option>
13% endfor
14</select>
15
9<%def name="title()">16<%def name="title()">
10Progress for ${lane}17Progress for ${lane_title}
11</%def>18</%def>
1219
13<h1>${title()}</h1>20<h1>${title()}</h1>
@@ -16,7 +23,7 @@
16<p><b>${status['name']}</b>23<p><b>${status['name']}</b>
17% for card in status['cards']:24% for card in status['cards']:
1825
19<table>26<table width="45%">
20<thead>27<thead>
21 <tr><th>28 <tr><th>
22 <a href="roadmap-card-${card.roadmap_id}.html">${card.name}</a>29 <a href="roadmap-card-${card.roadmap_id}.html">${card.name}</a>

Subscribers

People subscribed via source and target branches

to all changes: