Merge lp:~mabac/launchpad-work-items-tracker/linaro-roadmap-frontpage into lp:launchpad-work-items-tracker

Proposed by Mattias Backman
Status: Superseded
Proposed branch: lp:~mabac/launchpad-work-items-tracker/linaro-roadmap-frontpage
Merge into: lp:launchpad-work-items-tracker
Prerequisite: lp:~mabac/launchpad-work-items-tracker/linaro-roadmap-add-priority
Diff against target: 122 lines (+20/-9) (has conflicts)
6 files modified
collect_roadmap (+4/-0)
generate-all (+0/-5)
html-report (+3/-1)
lpworkitems/database.py (+2/-0)
lpworkitems/models_roadmap.py (+2/-1)
templates/roadmap_lane.html (+9/-2)
Text conflict in generate-all
Text conflict in report_tools.py
To merge this branch: bzr merge lp:~mabac/launchpad-work-items-tracker/linaro-roadmap-frontpage
Reviewer Review Type Date Requested Status
James Westby (community) Approve
Review via email: mp+79839@code.launchpad.net

This proposal has been superseded by a proposal from 2011-10-20.

Description of the change

Hi,

This branch removes the roadmap.html front page and adds a drop down selector on the lane view pages.

Also make the cards in the lanes view equal width by setting all of them to occupy 45% screen width.

Thanks,

Mattias

To post a comment you must log in.
Revision history for this message
James Westby (james-w) :
review: Approve

Unmerged revisions

308. By Mattias Backman

Make the current lane default in the selection dropdown.

307. By Mattias Backman

Make all card equal width in lane view.

306. By Mattias Backman

Put a lane selector on top of the Lane views.

305. By Mattias Backman

Don't generate roadmap.html.

304. By Mattias Backman

Mark lane as current based on name.

303. By Mattias Backman

Merge get-priority.

302. By Mattias Backman

Add is_current to Lane.

301. By Mattias Backman

Ignore the Legend and Deferred lanes as well as Summits cards. Also change the board id.

300. By Mattias Backman

Add Roadmap cards to Linaro roadmap reporting.

299. By Mattias Backman

Use the same lock for collect_roadmap as is used for collect.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'collect_roadmap'
2--- collect_roadmap 2011-10-19 15:17:01 +0000
3+++ collect_roadmap 2011-10-19 15:17:02 +0000
4@@ -75,6 +75,10 @@
5 assert node['parent_id'] == root_node_id
6 model_lane = Lane(unicode_or_None(node['name']),
7 node['id'])
8+ if model_lane.name == '2011Q3':
9+ model_lane.is_current = True
10+ else:
11+ model_lane.is_current = False
12 collector.store_lane(model_lane)
13 node_id = node['id']
14 if node_id in nodes:
15
16=== modified file 'generate-all'
17--- generate-all 2011-10-19 15:17:01 +0000
18+++ generate-all 2011-10-19 15:17:02 +0000
19@@ -170,11 +170,6 @@
20 basename = os.path.join(opts.output_dir, 'index')
21 report_tools.status_overview(my_path, opts.database, basename, opts.config, root=opts.root)
22
23-# roadmap overview
24-basename = os.path.join(opts.output_dir, 'roadmap')
25-report_tools.roadmap_overview(my_path, opts.database, basename, opts.config,
26- root=opts.root)
27-
28 # roadmap lanes
29 for lane in report_tools.lanes(store):
30 basename = os.path.join(opts.output_dir, 'roadmap-' + lane.name)
31
32=== modified file 'html-report'
33--- html-report 2011-10-19 15:17:01 +0000
34+++ html-report 2011-10-19 15:17:02 +0000
35@@ -478,13 +478,15 @@
36
37 data = self.template_data(store, opts)
38 lane = report_tools.lane(store, opts.lane).one()
39+ lanes = report_tools.lanes(store)
40 statuses = []
41 for status, cards in report_tools.statuses(store, lane):
42 statuses.append(dict(name=status, cards=cards))
43
44 data.update(dict(statuses=statuses))
45 data.update(dict(page_type="roadmap_lane"))
46- data.update(dict(lane=title))
47+ data.update(dict(lane_title=title))
48+ data.update(dict(lanes=lanes))
49 print report_tools.fill_template(
50 "roadmap_lane.html", data, theme=opts.theme)
51
52
53=== modified file 'lpworkitems/database.py'
54--- lpworkitems/database.py 2011-10-19 15:17:01 +0000
55+++ lpworkitems/database.py 2011-10-19 15:17:02 +0000
56@@ -93,6 +93,7 @@
57 store.execute('''CREATE TABLE lane (
58 name VARCHAR(200) NOT NULL,
59 lane_id NOT NULL,
60+ is_current BOOLEAN,
61 cards REFERENCES card(card_id)
62 )''')
63
64@@ -225,6 +226,7 @@
65 store.execute('ALTER TABLE card ADD COLUMN contact VARCHAR(50)')
66 store.execute('ALTER TABLE card ADD COLUMN description BLOB')
67 store.execute('ALTER TABLE card ADD COLUMN acceptance_criteria BLOB')
68+ store.execute('ALTER TABLE lane ADD COLUMN is_current BOOLEAN')
69 store.execute('UPDATE version SET db_layout_ref = 13')
70
71
72
73=== modified file 'lpworkitems/models_roadmap.py'
74--- lpworkitems/models_roadmap.py 2011-10-19 15:17:01 +0000
75+++ lpworkitems/models_roadmap.py 2011-10-19 15:17:02 +0000
76@@ -2,7 +2,7 @@
77 import re
78 from utils import unicode_or_None
79
80-from storm.locals import Date, Reference, ReferenceSet, Unicode, Int
81+from storm.locals import Date, Reference, ReferenceSet, Unicode, Int, Bool
82
83
84 class Card(object):
85@@ -35,6 +35,7 @@
86
87 name = Unicode()
88 lane_id = Int(primary=True)
89+ is_current = Bool()
90 cards = ReferenceSet(lane_id, Card.lane_id)
91
92 def __init__(self, name, lane_id):
93
94=== modified file 'templates/roadmap_lane.html'
95--- templates/roadmap_lane.html 2011-10-19 15:17:01 +0000
96+++ templates/roadmap_lane.html 2011-10-19 15:17:02 +0000
97@@ -6,8 +6,15 @@
98 import report_tools
99 %>
100
101+Lane to view:
102+<select name="laneselect" onchange="window.location=this.value;">
103+% for lane in lanes:
104+<option value="roadmap-${lane.name}.html"${' selected="selected"' if lane.name == lane_title else ''}>${lane.name}${' (current)' if lane.is_current else ''}</option>
105+% endfor
106+</select>
107+
108 <%def name="title()">
109-Progress for ${lane}
110+Progress for ${lane_title}
111 </%def>
112
113 <h1>${title()}</h1>
114@@ -16,7 +23,7 @@
115 <p><b>${status['name']}</b>
116 % for card in status['cards']:
117
118-<table>
119+<table width="45%">
120 <thead>
121 <tr><th>
122 <a href="roadmap-card-${card.roadmap_id}.html">${card.name}</a>

Subscribers

People subscribed via source and target branches

to all changes: