Merge lp:~mabac/launchpad-work-items-tracker/linaro-roadmap-connect-hacking into lp:~linaro-automation/launchpad-work-items-tracker/linaro

[Mattias Backman]

Hi,

This branch contains some changes back and forth and is a bit big. I hope it is reviewable though, if it's not I'll work on breaking it down in smaller chunks.

The main thing this adds is some plumbing for card health checks and a first set of checks.

It also changes the way information is displayed after feedback at the Connect. There is more to do, but I'd like to get this landed so we can start making smaller changes step by step.

Thanks,

Mattias

[Guilherme Salgado (salgado)]

Hi Mattias,

This looks quite good. I have a few questions below but I don't think
I've ever touched this code so please forgive me if any of them are
stupid. :)

On Mon, 2011-11-21 at 15:23 +0000, Mattias Backman wrote:
[...]
>
> This branch contains some changes back and forth and is a bit big. I
> hope it is reviewable though, if it's not I'll work on breaking it
> down in smaller chunks.

It's not too big in fact, and although a very long diff is no fun, what
is less fun is when there are lots of unrelated changes bundled together
in a single branch. I hope that's not the case here! ;)

>
> The main thing this adds is some plumbing for card health checks and a
> first set of checks.
>
> It also changes the way information is displayed after feedback at the
> Connect. There is more to do, but I'd like to get this landed so we
> can start making smaller changes step by step.

> === modified file 'collect_roadmap'
> --- collect_roadmap 2011-10-27 13:23:14 +0000
> +++ collect_roadmap 2011-11-21 15:22:45 +0000
> @@ -53,7 +53,7 @@
> def kanban_import_lanes(collector, workflow_stages):
> nodes = {}
> root_node_id = None
> - lanes_to_ignore = ['Legend', 'Deferred']
> + lanes_to_ignore = ['Legend']
>
> # Iterate over all workflow_stages which may be in any order.
> for workflow_stage in workflow_stages:
> @@ -75,7 +75,7 @@
> assert node['parent_id'] == root_node_id
> model_lane = Lane(unicode_or_None(node['name']),
> node['id'])
> - if model_lane.name == '2011Q3':
> + if model_lane.name == '2011Q4':

Would it be worth moving this to a constant?

> model_lane.is_current = True
> else:
> model_lane.is_current = False
> @@ -116,21 +116,30 @@
> unicode_or_None(task['task']['external_id']))
> model_card.status = unicode_or_None(task_status['name'])
> model_card.team = unicode_or_None(card_type_name)
> - model_card.priority = u"%s" % task['task']['priority']
> + model_card.priority = lookup_kanban_priority(task['task']['priority'])
> model_card.size = unicode_or_None(task['task']['size_estimate'])
> model_card.sponsor = unicode_or_None(task['task']['custom_field_1'])
>
> external_link = task['task']['external_link']
> - if external_link is not None:
> + if external_link is not None and external_link is not '':
> + model_card.url = unicode_or_None(external_link)
> + dbg('Getting Papyrs information from %s.' % external_link)
> papyrs_data = papyrs_import(collector, external_link)
> model_card.description = unicode_or_None(papyrs_data['description'])
> model_card.acceptance_criteria = unicode_or_None(papyrs_data['acceptance_criteria'])
> -
> collector.store_card(model_card)
> else:
> dbg("Task '%s' does not have a status." % task['task']['name'])
>
>
> +def lookup_kanban_priority(numeric_priority):
> + priority...

[Mattias Backman (mabac)]

On Mon, Nov 21, 2011 at 10:22 PM, Guilherme Salgado
<email address hidden> wrote:
> Hi Mattias,
>
> This looks quite good. I have a few questions below but I don't think
> I've ever touched this code so please forgive me if any of them are
> stupid. :)
>
> On Mon, 2011-11-21 at 15:23 +0000, Mattias Backman wrote:
> [...]
>>
>> This branch contains some changes back and forth and is a bit big. I
>> hope it is reviewable though, if it's not I'll work on breaking it
>> down in smaller chunks.
>
> It's not too big in fact, and although a very long diff is no fun, what
> is less fun is when there are lots of unrelated changes bundled together
> in a single branch. I hope that's not the case here! ;)

As you've seen it's a bit like that. :/

>
>>
>> The main thing this adds is some plumbing for card health checks and a
>> first set of checks.
>>
>> It also changes the way information is displayed after feedback at the
>> Connect. There is more to do, but I'd like to get this landed so we
>> can start making smaller changes step by step.
>
>> === modified file 'collect_roadmap'
>> --- collect_roadmap   2011-10-27 13:23:14 +0000
>> +++ collect_roadmap   2011-11-21 15:22:45 +0000
>> @@ -53,7 +53,7 @@
>>  def kanban_import_lanes(collector, workflow_stages):
>>      nodes = {}
>>      root_node_id = None
>> -    lanes_to_ignore = ['Legend', 'Deferred']
>> +    lanes_to_ignore = ['Legend']
>>
>>      # Iterate over all workflow_stages which may be in any order.
>>      for workflow_stage in workflow_stages:
>> @@ -75,7 +75,7 @@
>>          assert node['parent_id'] == root_node_id
>>          model_lane = Lane(unicode_or_None(node['name']),
>>                            node['id'])
>> -        if model_lane.name == '2011Q3':
>> +        if model_lane.name == '2011Q4':
>
> Would it be worth moving this to a constant?

We should actually move it to an external config of some sort. That
reminds me to talk to Joey about if this can be a flag on the lanes in
Kanbantool. I'll get back to you on that one.

>
>>              model_lane.is_current = True
>>          else:
>>              model_lane.is_current = False
>> @@ -116,21 +116,30 @@
>>                                    unicode_or_None(task['task']['external_id']))
>>                  model_card.status = unicode_or_None(task_status['name'])
>>                  model_card.team = unicode_or_None(card_type_name)
>> -                model_card.priority = u"%s" % task['task']['priority']
>> +                model_card.priority = lookup_kanban_priority(task['task']['priority'])
>>                  model_card.size = unicode_or_None(task['task']['size_estimate'])
>>                  model_card.sponsor = unicode_or_None(task['task']['custom_field_1'])
>>
>>                  external_link = task['task']['external_link']
>> -                if external_link is not None:
>> +                if external_link is not None and external_link is not '':
>> +                    model_card.url = unicode_or_None(external_link)
>> +                    dbg('Getting Papyrs information from %s.' % external_link)
>>                      papyrs_data = papyrs_import(collector, external_link)
>>                      model_car...

[Guilherme Salgado (salgado)]

On Tue, 2011-11-22 at 12:47 +0000, Mattias Backman wrote:
> On Mon, Nov 21, 2011 at 10:22 PM, Guilherme Salgado
> <email address hidden> wrote:
[...]
> > It's not too big in fact, and although a very long diff is no fun, what
> > is less fun is when there are lots of unrelated changes bundled together
> > in a single branch. I hope that's not the case here! ;)
>
> As you've seen it's a bit like that. :/

It was ok, actually. :)

> >>
> >> The main thing this adds is some plumbing for card health checks and a
> >> first set of checks.
> >>
> >> It also changes the way information is displayed after feedback at the
> >> Connect. There is more to do, but I'd like to get this landed so we
> >> can start making smaller changes step by step.
> >
> >> === modified file 'collect_roadmap'
> >> --- collect_roadmap 2011-10-27 13:23:14 +0000
> >> +++ collect_roadmap 2011-11-21 15:22:45 +0000
> >> @@ -53,7 +53,7 @@
> >> def kanban_import_lanes(collector, workflow_stages):
> >> nodes = {}
> >> root_node_id = None
> >> - lanes_to_ignore = ['Legend', 'Deferred']
> >> + lanes_to_ignore = ['Legend']
> >>
> >> # Iterate over all workflow_stages which may be in any order.
> >> for workflow_stage in workflow_stages:
> >> @@ -75,7 +75,7 @@
> >> assert node['parent_id'] == root_node_id
> >> model_lane = Lane(unicode_or_None(node['name']),
> >> node['id'])
> >> - if model_lane.name == '2011Q3':
> >> + if model_lane.name == '2011Q4':
> >
> > Would it be worth moving this to a constant?
>
> We should actually move it to an external config of some sort. That
> reminds me to talk to Joey about if this can be a flag on the lanes in
> Kanbantool. I'll get back to you on that one.

Ok, cool. If that's not possible then I'd be happy with a constant
defined at the top of this module.

> >> @@ -160,12 +169,22 @@
> >> last_heading = page_item['text']
> >> if page_item['classname'] == 'Paragraph':
> >> if not has_found_description:
> >> - description = page_item['text']
> >> + description = page_item['html']
> >
> > Why are we using the html instead of the plaintext version now?
>
> We don't want to loose the formatting that whoever edits the Papyrs
> document adds. It's also a practical thing since the text version is
> just the html stripped of markup. So lists end up as a sentence that
> do not make sense and paragraph breaks are lost (since they are <br>
> which are not translated to line breaks).

Oh, ok, that makes sense.

>
> >
> >> has_found_description = True
> >> - elif last_heading == 'Acceptance Criteria':
> >> - acceptance_criteria = page_item['text']
> >> -
> >> - return {'description': description, 'acceptance_criteria': acceptance_criteria}
> >> + elif 'Acceptance Criteria' in last_heading:
> >> + acceptance_criteria = page_item['html']
> >> +
> >> + return {'description': get_first_paragraph(description),
> >> + 'acceptance_criteria': get_first_paragraph(acceptance_criteria)}
> >> +
> >> +
> >> +def get_first_par...

[Mattias Backman (mabac)]

> On Tue, 2011-11-22 at 12:47 +0000, Mattias Backman wrote:
> > On Mon, Nov 21, 2011 at 10:22 PM, Guilherme Salgado
> > <email address hidden> wrote:
> [...]
> > > It's not too big in fact, and although a very long diff is no fun, what
> > > is less fun is when there are lots of unrelated changes bundled together
> > > in a single branch. I hope that's not the case here! ;)
> >
> > As you've seen it's a bit like that. :/
>
> It was ok, actually. :)
>
> > >>
> > >> The main thing this adds is some plumbing for card health checks and a
> > >> first set of checks.
> > >>
> > >> It also changes the way information is displayed after feedback at the
> > >> Connect. There is more to do, but I'd like to get this landed so we
> > >> can start making smaller changes step by step.
> > >
> > >> === modified file 'collect_roadmap'
> > >> --- collect_roadmap 2011-10-27 13:23:14 +0000
> > >> +++ collect_roadmap 2011-11-21 15:22:45 +0000
> > >> @@ -53,7 +53,7 @@
> > >> def kanban_import_lanes(collector, workflow_stages):
> > >> nodes = {}
> > >> root_node_id = None
> > >> - lanes_to_ignore = ['Legend', 'Deferred']
> > >> + lanes_to_ignore = ['Legend']
> > >>
> > >> # Iterate over all workflow_stages which may be in any order.
> > >> for workflow_stage in workflow_stages:
> > >> @@ -75,7 +75,7 @@
> > >> assert node['parent_id'] == root_node_id
> > >> model_lane = Lane(unicode_or_None(node['name']),
> > >> node['id'])
> > >> - if model_lane.name == '2011Q3':
> > >> + if model_lane.name == '2011Q4':
> > >
> > > Would it be worth moving this to a constant?
> >
> > We should actually move it to an external config of some sort. That
> > reminds me to talk to Joey about if this can be a flag on the lanes in
> > Kanbantool. I'll get back to you on that one.
>
> Ok, cool. If that's not possible then I'd be happy with a constant
> defined at the top of this module.

Apparently there is no data for a Lane except for it's name. So I'll go with the constant and we can change it to an external config when we need to.

>
> > >> @@ -160,12 +169,22 @@
> > >> last_heading = page_item['text']
> > >> if page_item['classname'] == 'Paragraph':
> > >> if not has_found_description:
> > >> - description = page_item['text']
> > >> + description = page_item['html']
> > >
> > > Why are we using the html instead of the plaintext version now?
> >
> > We don't want to loose the formatting that whoever edits the Papyrs
> > document adds. It's also a practical thing since the text version is
> > just the html stripped of markup. So lists end up as a sentence that
> > do not make sense and paragraph breaks are lost (since they are <br>
> > which are not translated to line breaks).
>
> Oh, ok, that makes sense.
>
> >
> > >
> > >> has_found_description = True
> > >> - elif last_heading == 'Acceptance Criteria':
> > >> - acceptance_criteria = page_item['text']
> > >> -
> > >> - return {'description': description, 'acceptance_criteria':
> acceptance_criteria}
> > >> + elif...

[Guilherme Salgado (salgado)]

On Wed, 2011-11-23 at 08:46 +0000, Mattias Backman wrote:
[...]
> > > >
> > > >> has_found_description = True
> > > >> - elif last_heading == 'Acceptance Criteria':
> > > >> - acceptance_criteria = page_item['text']
> > > >> -
> > > >> - return {'description': description, 'acceptance_criteria':
> > acceptance_criteria}
> > > >> + elif 'Acceptance Criteria' in last_heading:
> > > >> + acceptance_criteria = page_item['html']
> > > >> +
> > > >> + return {'description': get_first_paragraph(description),
> > > >> + 'acceptance_criteria':
> > get_first_paragraph(acceptance_criteria)}
> > > >> +
> > > >> +
> > > >> +def get_first_paragraph(text):
> > > >> + if text is None:
> > > >> + return None
> > > >> + # This might break, depending on what type of line breaks
> > > >> + # whoever authors the Papyrs document uses.
> > > >> + first_pararaph, _, _ = text.partition('<br>')
> > > >
> > > > Would it be possible to use something like BeautifulSoup to make this
> > > > more robust?
> > >
> > > Possibly. I can have a look at what it can do. This seemed to work but
> > > now I see that someone has added BRs just before a list too which gets
> > > ugly.
> >
> > What does the HTML you're parsing look like? On, say
> > https://linaro-public.papyrs.com/public/4552/KWG2011-AMP-IPC/, I see the
> > actual content in a javascript function, so I'm assuming you're parsing
> > something else?
>
> Here's one example with a list: http://paste.ubuntu.com/746780/
> Sorry that it's all on one line. I get it from the json API, but it's
> not much better than scraping that javascript. Sometimes we get
> whitespace with a lot of formatting around it, just like when people
> edit html using MS Word.

Ok, apparently there's not much structure on the HTML; just some lists
and <br>s to force line breaks, so I think BeautifulSoup wouldn't help
much here.

> >
> > > >
> > > >> + return first_pararaph
> > > >>
> > > >>
> > > >> ########################################################################
> > > >
> > > >
> > > >> === modified file 'report_tools.py'
> > > >> --- report_tools.py 2011-10-24 15:08:02 +0000
> > > >> +++ report_tools.py 2011-11-21 15:22:45 +0000
[...]
> > > >
> > > > Having all the classes here make for a rather long function. Is there a
> > > > reason for keeping them here other than the fact that they're not used
> > > > anywhere else?
> > >
> > > I wasn't even sure that creating subclasses would be a good idea.
> > > Since i fear that we will see a lot more checks when PMs know what
> > > they want I guess these should go on a module instead.
> > >
> > > >
> > > >> +
> > > >> + health_checks = []
> > > >> + health_checks.append(RoadmapIdHealthCheck())
> > > >> + health_checks.append(DescriptionHealthCheck())
> > > >> + health_checks.append(CriteriaHealthCheck())
> > > >> + health_checks.append(BlueprintsHealthCheck())
> > > >> + health_checks.append(BlueprintsBlockedHealthCheck())
> > > >
> > > > One neat thing we could do is use a class decorator on all HealthCheck
> > > > classes to register them on a global registry (a...

review: Approve

[Mattias Backman (mabac)]

I have fixed the pep8 and constant suggestions and used Salgado's
magic to move the health checks to a separate module.

Some items (mostly visual stuff from kiko) carry over and have been
registered in a new bp.

On Thu, Nov 24, 2011 at 11:45 AM, <email address hidden> wrote:
> The proposal to merge lp:~mabac/launchpad-work-items-tracker/linaro-roadmap-connect-hacking into lp:~linaro-infrastructure/launchpad-work-items-tracker/linaro has been updated.
>
>    Status: Needs review => Merged
>
> For more details, see:
> https://code.launchpad.net/~mabac/launchpad-work-items-tracker/linaro-roadmap-connect-hacking/+merge/82898
> --
> https://code.launchpad.net/~mabac/launchpad-work-items-tracker/linaro-roadmap-connect-hacking/+merge/82898
> You are the owner of lp:~mabac/launchpad-work-items-tracker/linaro-roadmap-connect-hacking.
>

=== modified file 'collect_roadmap'
--- collect_roadmap	2011-10-27 13:23:14 +0000
+++ collect_roadmap	2011-11-21 15:22:45 +0000
@@ -53,7 +53,7 @@
 def kanban_import_lanes(collector, workflow_stages):
     nodes = {}
     root_node_id = None
-    lanes_to_ignore = ['Legend', 'Deferred']
+    lanes_to_ignore = ['Legend']
 
     # Iterate over all workflow_stages which may be in any order.
     for workflow_stage in workflow_stages:
@@ -75,7 +75,7 @@
         assert node['parent_id'] == root_node_id
         model_lane = Lane(unicode_or_None(node['name']),
                           node['id'])
-        if model_lane.name == '2011Q3':
+        if model_lane.name == '2011Q4':
             model_lane.is_current = True
         else:
             model_lane.is_current = False
@@ -116,21 +116,30 @@
                                   unicode_or_None(task['task']['external_id']))
                 model_card.status = unicode_or_None(task_status['name'])
                 model_card.team = unicode_or_None(card_type_name)
-                model_card.priority = u"%s" % task['task']['priority']
+                model_card.priority = lookup_kanban_priority(task['task']['priority'])
                 model_card.size = unicode_or_None(task['task']['size_estimate'])
                 model_card.sponsor = unicode_or_None(task['task']['custom_field_1'])
 
                 external_link = task['task']['external_link']
-                if external_link is not None:
+                if external_link is not None and external_link is not '':
+                    model_card.url = unicode_or_None(external_link)
+                    dbg('Getting Papyrs information from %s.' % external_link)
                     papyrs_data = papyrs_import(collector, external_link)
                     model_card.description = unicode_or_None(papyrs_data['description'])
                     model_card.acceptance_criteria = unicode_or_None(papyrs_data['acceptance_criteria'])
-
                 collector.store_card(model_card)
         else:
             dbg("Task '%s' does not have a status." % task['task']['name'])
 
 
+def lookup_kanban_priority(numeric_priority):
+    priority_lookup = { -1 : "low",
+                         0 : "normal",
+                         1 : "high" }
+    assert numeric_priority in priority_lookup, (
+        "Priority '%s' is unknown." % numeric_priority)
+    return unicode_or_None(priority_lookup[numeric_priority])
+
 def kanban_import(collector, cfg, board_id, api_token):
     '''Collect roadmap items from KanbanTool into DB.'''
     board_url = get_kanban_url('boards/%s.json' % board_id, api_token)
@@ -150,7 +159,7 @@
     acceptance_criteria = None
 
     page = get_json_data(requirement_url + '?json&auth_token=e8a2801e4f0f')
-
+    assert page is not None, "Could not access Papyrs document %s." % requirement_url
     page_text_items = page[0]
     page_extra_items = page[1]
 
@@ -160,12 +169,22 @@
             last_heading = page_item['text']
         if page_item['classname'] == 'Paragraph':
             if not has_found_description:
-                description = page_item['text']
+                description = page_item['html']
                 has_found_description = True
-            elif last_heading == 'Acceptance Criteria':
-                acceptance_criteria = page_item['text']
-
-    return {'description': description, 'acceptance_criteria': acceptance_criteria}
+            elif 'Acceptance Criteria' in last_heading:
+                acceptance_criteria = page_item['html']
+
+    return {'description': get_first_paragraph(description),
+            'acceptance_criteria': get_first_paragraph(acceptance_criteria)}
+
+
+def get_first_paragraph(text):
+    if text is None:
+        return None
+    # This might break, depending on what type of line breaks
+    # whoever authors the Papyrs document uses.
+    first_pararaph, _, _ = text.partition('<br>')
+    return first_pararaph
 
 
 ########################################################################

=== modified file 'generate-all'
--- generate-all	2011-10-18 11:34:41 +0000
+++ generate-all	2011-11-21 15:22:45 +0000
@@ -159,9 +159,13 @@
 
 # roadmap cards
 for card in report_tools.cards(store):
-    basename = os.path.join(opts.output_dir, 'roadmap-card-%s' % \
-                                card.roadmap_id)
-    report_tools.roadmap_cards(my_path, opts.database, basename, opts.config, card, root=opts.root)
+    if card.roadmap_id != '':
+        page_name = card.roadmap_id
+    else:
+        page_name = card.card_id
+    basename = os.path.join(opts.output_dir, 'roadmap-card-%s' % page_name)
+    report_tools.roadmap_cards(my_path, opts.database, basename, opts.config,
+                               card, root=opts.root)
 
 def copy_files(source_dir):
     for filename in os.listdir(source_dir):

=== modified file 'html-report'
--- html-report	2011-10-27 12:20:51 +0000
+++ html-report	2011-11-21 15:22:45 +0000
@@ -474,20 +474,16 @@
             title = opts.title
 
         data = self.template_data(store, opts)
-        lane = report_tools.lane(store, opts.lane).one()
+        lane = report_tools.lane(store, opts.lane)
         lanes = report_tools.lanes(store)
         statuses = []
         for status, cards in report_tools.statuses(store, lane):
-            cards_with_bp_counts = []
+            cards_with_bps = []
             for card in cards:
+                report_tools.check_card_health(store, card)
                 blueprints = report_tools.card_blueprints_by_status(store, card.roadmap_id)
-                count_string = ''
-                for bp_status in blueprints.keys():
-                    bp_count = len(blueprints[bp_status])
-                    if bp_count > 0:
-                        count_string += '%s: %d ' % (bp_status, bp_count)
-                cards_with_bp_counts.append({'card': card, 'count': count_string})
-            statuses.append(dict(name=status, cards=cards_with_bp_counts))
+                cards_with_bps.append({'card': card, 'blueprints': blueprints})
+            statuses.append(dict(name=status, cards=cards_with_bps))
             
         data.update(dict(statuses=statuses))
         data.update(dict(page_type="roadmap_lane"))
@@ -503,7 +499,8 @@
 
         data = self.template_data(store, opts)
         card = report_tools.card(store, int(opts.card)).one()
-        lane = report_tools.lane(store, None, id=card.lane_id).one()
+        health_checks = report_tools.check_card_health(store, card)
+        lane = report_tools.lane(store, None, id=card.lane_id)
 
         if not opts.title:
             title = card.name
@@ -511,12 +508,20 @@
             title = opts.title
 
         blueprints = report_tools.card_blueprints_by_status(store, card.roadmap_id)
+        blueprint_status_count = WorkitemTarget()
+        blueprint_status_count.todo = len(blueprints['Planned'])
+        blueprint_status_count.blocked = len(blueprints['Blocked'])
+        blueprint_status_count.inprogress = len(blueprints['In Progress'])
+        blueprint_status_count.postponed = 0
+        blueprint_status_count.done = len(blueprints['Completed'])
 
         data.update(dict(page_type="roadmap_card"))
         data.update(dict(card_title=title))
         data.update(dict(card=card))
+        data.update(dict(health_checks=health_checks))
         data.update(dict(lane=lane.name))
         data.update(dict(blueprints=blueprints))
+        data.update(dict(blueprint_status_count=blueprint_status_count))
 
         print report_tools.fill_template(
             "roadmap_card.html", data, theme=opts.theme)

=== modified file 'lpworkitems/database.py'
--- lpworkitems/database.py	2011-10-13 15:31:42 +0000
+++ lpworkitems/database.py	2011-11-21 15:22:45 +0000
@@ -7,7 +7,7 @@
     store.execute('''CREATE TABLE version (
         db_layout_ref INT NOT NULL
         )''')
-    store.execute('''INSERT INTO version VALUES (13)''')
+    store.execute('''INSERT INTO version VALUES (14)''')
 
     store.execute('''CREATE TABLE specs (
         name VARCHAR(255) PRIMARY KEY,
@@ -100,6 +100,8 @@
     store.execute('''CREATE TABLE card (
         name VARCHAR(200) NOT NULL,
         card_id NOT NULL,
+        url VARCHAR(200),
+        is_healthy BOOLEAN,
         status VARCHAR(50),
         team VARCHAR(50),
         priority VARCHAR(50),
@@ -228,6 +230,10 @@
         store.execute('ALTER TABLE card ADD COLUMN acceptance_criteria BLOB')
         store.execute('ALTER TABLE lane ADD COLUMN is_current BOOLEAN')
         store.execute('UPDATE version SET db_layout_ref = 13')
+    if ver == 13:
+        store.execute('ALTER TABLE card ADD COLUMN url VARCHAR(200)')
+        store.execute('ALTER TABLE card ADD COLUMN is_healthy BOOLEAN')
+        store.execute('UPDATE version SET db_layout_ref = 14')
 
 
 def get_store(dbpath):

=== modified file 'lpworkitems/models_roadmap.py'
--- lpworkitems/models_roadmap.py	2011-10-13 15:31:42 +0000
+++ lpworkitems/models_roadmap.py	2011-11-21 15:22:45 +0000
@@ -21,6 +21,8 @@
     contact = Unicode()
     description = Unicode()
     acceptance_criteria = Unicode()
+    url = Unicode()
+    is_healthy = Bool()
 
     def __init__(self, name, card_id, lane_id, roadmap_id):
         self.lane_id = lane_id

=== modified file 'report_tools.py'
--- report_tools.py	2011-10-24 15:08:02 +0000
+++ report_tools.py	2011-11-21 15:22:45 +0000
@@ -942,14 +942,15 @@
 
 def lane(store, name, id=None):
     if id is None:
-        return store.find(Lane, Lane.name == unicode(name))
+        return store.find(Lane, Lane.name == unicode(name)).one()
     else:
-        return store.find(Lane, Lane.lane_id == id)
+        return store.find(Lane, Lane.lane_id == id).one()
 
 
 def lane_cards(store, lane):
     return lane.cards
 
+
 def statuses(store, lane):
     result = []
     for status in store.find(Card.status,
@@ -995,6 +996,91 @@
     return bp_by_status
 
 
+def check_card_health(store, card):
+    class HealthCheck(object):
+        NOT_APPLICABLE = 'n/a'
+        OK = 'OK'
+        NOT_OK = 'Not OK'
+        name = 'Base check, not to be used'
+
+        def applicable(self, card, store=None):
+            raise NotImplementedError()
+
+        def check(self, card, store=None):
+            raise NotImplementedError()
+            
+        def execute(self, card, store=None):
+            if self.applicable(card, store):
+                if self.check(card, store):
+                    return self.OK
+                else:
+                    return self.NOT_OK
+            else:
+                return self.NOT_APPLICABLE
+
+    class DescriptionHealthCheck(HealthCheck):
+        name = 'Has description'
+
+        def applicable(self, card, store=None):
+            return True
+
+        def check(self, card, store=None):
+            return card.description is not None
+
+    class CriteriaHealthCheck(HealthCheck):
+        name = 'Has acceptance criteria'
+
+        def applicable(self, card, store=None):
+            return True
+
+        def check(self, card, store=None):
+            return card.acceptance_criteria is not None
+
+    class BlueprintsHealthCheck(HealthCheck):
+        name = 'Has blueprints'
+
+        def applicable(self, card, store):
+            return card.status == 'Ready'
+
+        def check(self, card, store):
+            return len(card_blueprints(store, card.roadmap_id)) > 0
+
+    class BlueprintsBlockedHealthCheck(HealthCheck):
+        name = 'Has no Blocked blueprints'
+
+        def applicable(self, card, store):
+            return card.status != 'Ready'
+
+        def check(self, card, store):
+            blueprints = card_blueprints_by_status(store, card.roadmap_id)
+            return len(blueprints['Blocked']) == 0
+
+    class RoadmapIdHealthCheck(HealthCheck):
+        name = 'Has a roadmap id'
+
+        def applicable(self, card, store=None):
+            return True
+
+        def check(self, card, store=None):
+            return card.roadmap_id != ''
+
+    health_checks = []
+    health_checks.append(RoadmapIdHealthCheck())
+    health_checks.append(DescriptionHealthCheck())
+    health_checks.append(CriteriaHealthCheck())
+    health_checks.append(BlueprintsHealthCheck())
+    health_checks.append(BlueprintsBlockedHealthCheck())
+
+    performed_checks = []
+    card.is_healthy = True
+    for check in health_checks:
+        result = check.execute(card, store)
+        if result == check.NOT_OK:
+            card.is_healthy = False
+        performed_checks.append({'name': check.name,
+                                 'result': result})
+    return performed_checks
+
 def subteams(store, team):
     result = store.execute('SELECT name from team_structure where team = ?', (unicode(team),))
     return [i[0] for i in result]

=== modified file 'templates/roadmap_card.html'
--- templates/roadmap_card.html	2011-10-31 16:12:14 +0000
+++ templates/roadmap_card.html	2011-11-21 15:22:45 +0000
@@ -14,8 +14,6 @@
 <h2>${card.status} in <a href="roadmap-${lane}.html">${lane}</a></h2>
 <p>
 <ul>
-    <li>Description: ${card.description[:250]}
-    <li>Acceptance criteria: ${card.acceptance_criteria[:250]}
     <li>Sponsor: ${card.sponsor}
     <li>Contact: ${card.contact}
     <li>Priority: ${card.priority}
@@ -23,12 +21,15 @@
     <li>Team: ${card.team}
 </ul>
 
+<div style="text-align: center">Overall blueprint completion</div>
+${util.progress_bar(blueprint_status_count)}
+
+<h3>Description</h3> ${card.description if card.description is not None else '<i>No description could be found.</i>'}
+<p><a href="${card.url}">Read the full description</a>.
+<h3>Acceptance criteria</h3> ${card.acceptance_criteria if card.acceptance_criteria is not None else '<i>No acceptance criteria could be found.</i>'}
+<p><a href="${card.url}">Read the full acceptance criteria</a>.
 <p>
-% for status in blueprints.keys():
-% if blueprints[status] == []:
-<p><i>There are no ${status} blueprints linked to this card.</i>
-% else:
-<h3>${status}</h3>
+% if card.status in ['Ready', 'Delivered'] or blueprints.keys() > 0:
 <table>
 <thead>
     <tr><th>Title</th>
@@ -39,47 +40,27 @@
     <th>Health check</th>
     </tr>
 </thead>
+% for status in blueprints.keys():
 % for bp in blueprints[status]:
     <tr><td><a href="${bp.url}">${bp.name}</a></td>
     <td>${bp.assignee_name}</td>
     <td>${bp.priority}</td>
-    <td>${bp.implementation}</td>
+    <td>${status}
     <td>${bp.milestone_name}</td>
-    <td>xxx</td>
+    <td></td>
     </tr>
 % endfor
+% endfor
 </table>
 % endif
-% endfor
 
 <h3>Health check</h3>
-<table>
-    <tr><td>Has Description</td>
-    <td>
-% if description == "":
-        No
-% else:
-        Yes
-% endif
-    </td></tr>
-    <tr><td>Has Acceptance Criteria</td>
-    <td>
-% if acceptance_criteria == "":
-        No
-% else:
-        Yes
-% endif
-    </td></tr>
-    <tr><td>Has Blueprints</td>
-    <td>
-% if blueprints == []:
-        No
-% else:
-        Yes
-% endif
-    </td></tr>
-    <tr><td>Is Ready</td>
-    <td>
-        TODO
-    </td></tr>
+
+<table>${'<tr colspan="2"><td><font color="#FF0000"><b>Needs attention!</b></font></td></tr>' if not card.is_healthy else ''}
+ % for result in health_checks:
+    <tr ${'bgcolor="#FFAAAA"' if result['result'] == 'Not OK' else 'bgcolor="#FFFFFF"'}>
+        <td>${result['name']}</td>
+        <td>${result['result']}</td>
+</tr>
+% endfor
 </table>

=== modified file 'templates/roadmap_lane.html'
--- templates/roadmap_lane.html	2011-10-31 16:12:14 +0000
+++ templates/roadmap_lane.html	2011-11-21 15:22:45 +0000
@@ -19,22 +19,26 @@
 
 <h1>${title()}</h1>
 <p>
+<table>
+<thead><tr><th>Card</th><th>Status</th><th>Team</th><th>Priority</th><th>Blueprints</th><th>Health</th></tr></thead>
 % for status in statuses:
-<p><b>${status['name']}</b>
 % for card_dict in status['cards']:
-<table width="45%">
-<thead>
-    <tr><th>
-        <a href="roadmap-card-${card_dict['card'].roadmap_id}.html">${card_dict['card'].name}</a>
-    </th></tr>
-</thead>
-    <tr><td colspan=2>${card_dict['card'].description[:200]}</td></tr>
-    <tr><td>
-	${card_dict['count']}
-    </td><td>&nbsp</td></tr>
-    <tr><td>${card_dict['card'].team}</td><td align=right>Priority ${card_dict['card'].priority}</td></tr>
+    <tr>
+    <td>
+        <a href="roadmap-card-${card_dict['card'].roadmap_id if card_dict['card'].roadmap_id != '' else card_dict['card'].card_id}.html">${card_dict['card'].name}</a>
+    </td>
+    <td>${status['name']}</td>
+    <!--<td>${card_dict['card'].description} <a href="roadmap-card-${card_dict['card'].roadmap_id}.html">...</a></td> -->
+    <td>${card_dict['card'].team}</td><td align=right>${card_dict['card'].priority}</td>
+    <td>
+% for bp_status in card_dict['blueprints'].keys():
+        ${'%s: %d ' % (bp_status, len(card_dict['blueprints'][bp_status])) if len(card_dict['blueprints'][bp_status]) > 0 else ''}
+% endfor
+    </td>
+    <td>
+        ${'<font color="#FF0000">Needs attention!</font>' if not card_dict['card'].is_healthy else ''}
+    </td>
+% endfor
+% endfor
 </table>
-<p><p>
-% endfor
-% endfor