Merge lp:~mabac/launchpad-work-items-tracker/fix-none-whiteboard into lp:~linaro-automation/launchpad-work-items-tracker/linaro

[Mattias Backman]

Hi,

This branch adds a check for the whiteboard being None before concatenating the workitems_text prior to parsing.

It seems that some (new?) blueprints have a None whiteboard.

Thanks,

Mattias

[Mattias Backman (mabac)]

This is in the middle of a lot of stuff so not trivial to add a test. Let this code base be a lesson to us all. ;)

[Guilherme Salgado (salgado)]

Looks good to me

review: Approve

[Mattias Backman (mabac)]

On Mon, Mar 26, 2012 at 2:29 PM, Guilherme Salgado
<email address hidden> wrote:
> Review: Approve
>
> Looks good to me

Thanks. Merged to linaro-staging and it looks good.

> --
> https://code.launchpad.net/~mabac/launchpad-work-items-tracker/fix-none-whiteboard/+merge/99294
> You are the owner of lp:~mabac/launchpad-work-items-tracker/fix-none-whiteboard.

=== modified file 'collect'
--- collect	2012-03-09 16:49:06 +0000
+++ collect	2012-03-26 11:45:22 +0000
@@ -214,6 +214,8 @@
     # whiteboard for work items we can change this to pull work items only
     # from bp.workitems_text.
     workitems_text = bp.whiteboard
+    if workitems_text is None:
+        workitems_text = ''
     if getattr(bp, 'workitems_text', '') != '':
         workitems_text += "\n" + bp.workitems_text
     if workitems_text: