Code review comment for lp:~mabac/launchpad-work-items-tracker/better-error-contacts

On 03/02/12 11:28, Mattias Backman wrote:
> On Fri, Feb 3, 2012 at 1:52 PM, Guilherme Salgado
> <email address hidden> wrote:
>> Yay! Thanks for working on this, Mattias.
>
> No problem. I'm also tired of getting spam about typos. ;)
>
>>
>> On 03/02/12 08:05, Mattias Backman wrote:
>>>
>>> === modified file 'collect'
>>> --- collect 2011-12-15 18:37:53 +0000
>>> +++ collect 2012-02-03 11:04:28 +0000
>>> @@ -667,9 +667,10 @@
>>> def send_error_mails(cfg):
>>> '''Send data_errors to contacts.
>>>
>>> - Data error contacts are defined in the configuration in the "error_contact"
>>> - map (which assigns a regexp over spec names to a list of email addresses).
>>> - If no match is found, the error goes to stderr.
>>> + Data error contacts are defined in the configuration in the
>>> + "project_notification_addresses" map (which assigns project names to a list
>>> + of email addresses). If no address list for a project is found, the error
>>> + goes to stderr.
>>
>> I wonder if we should make the contact address required...
>
> Umm, yes we shouldn't have project groups without contact addresses.
> But I'd hate to break the update because of a bad config, so I'd
> prefer not to bail on it. Do you think we can handle this when
> reviewing config changes?

We don't have config changes too often, do we? And in most cases I've
seen they'd be just a matter of extending the list of projects of an
existing class, so wouldn't break anything. We could also add a small
test script to the config branch, just to do some sanity checking, but
that we can probably save for later.