Merge lp:~mabac/launchpad-work-items-tracker/better-config into lp:~linaro-automation/launchpad-work-items-tracker/linaro-config

[Mattias Backman]

Hi,

This is the new config file format to go with lp:~mabac/launchpad-work-items-tracker/better-error-contacts

Thanks,

Mattias

[Mattias Backman (mabac)]

Fixed the conflict.

[lp:~mabac/launchpad-work-items-tracker/better-config]

43. By Mattias Backman on 2012-02-03

Merge from linaro-config to add Igloo project and contacts.

[Guilherme Salgado (salgado)]

This all looks good to me; I've just two comments.

First, I think the multimedia contact should be tom gall and not michael hope, no?

Second, we need to add contact addresses for the linaro project as well:
  # Linaro project to track
  project = 'linaro'
  project_series = 'trunk'

But given that's not in extra_projects and we don't want it to be there, we should probably just add an entry for it at the end of project_notification_addresses instead of using a class for it.

Oh, and the indentation on line 207 seems to be off by one space.

Oh, and it'd be good to manually test that extra_projects in this config is identical to extra_projects in the old one; it should be trivial to load_config() both and compare extra_projects in both, right?

review: Approve

[Mattias Backman (mabac)]

On Fri, Feb 3, 2012 at 2:06 PM, Guilherme Salgado
<email address hidden> wrote:
> Review: Approve
>
> This all looks good to me; I've just two comments.
>
> First, I think the multimedia contact should be tom gall and not michael hope, no?

You're right.

>
> Second, we need to add contact addresses for the linaro project as well:
>  # Linaro project to track
>  project = 'linaro'
>  project_series = 'trunk'
>
> But given that's not in extra_projects and we don't want it to be there, we should probably just add an entry for it at the end of project_notification_addresses instead of using a class for it.

Yes, I forgot that project. Will add it like that.

>
> Oh, and the indentation on line 207 seems to be off by one space.

I shouldn't tell you that it actually was a tab...

>
> Oh, and it'd be good to manually test that extra_projects in this config is identical to extra_projects in the old one; it should be trivial to load_config() both and compare extra_projects in both, right?

Absolutely. I'll try that before giving it a spin on staging.

> --
> https://code.launchpad.net/~mabac/launchpad-work-items-tracker/better-config/+merge/91411
> You are the owner of lp:~mabac/launchpad-work-items-tracker/better-config.

[lp:~mabac/launchpad-work-items-tracker/better-config]

44. By Mattias Backman on 2012-02-03

Fix review comments. Thanks salgado.

=== modified file 'current.cfg'
--- current.cfg	2012-02-02 14:12:16 +0000
+++ current.cfg	2012-02-03 14:55:19 +0000
@@ -31,23 +31,6 @@
 # any teams to recurse into
 recursive_teams = ['linaro']
 
-################
-# Error emails #
-################
-# contact points for data errors (regexps on spec name pattern)
-error_contact = {
-    'linaro.*graphics': ['[e-mail]', '[e-mail]'],
-    'linaro.*toolchain': ['[e-mail]', '[e-mail]'],
-    'linaro.*kernel': ['[e-mail]', '[e-mail]'],
-    'kernel-.*': ['[e-mail]', '[e-mail]'],
-    'linaro.*power': ['[e-mail]', '[e-mail]'],
-    'linaro.*octo': ['[e-mail]', '[e-mail]'],
-    'linaro.*android': ['[e-mail]', '[e-mail]', '[e-mail]', '[e-mail]'],
-    'android-.*': ['[e-mail]', '[e-mail]', '[e-mail]', '[e-mail]'],
-    'linaro.*platforms': ['[e-mail]', '[e-mail]', '[e-mail]', '[e-mail]', '[e-mail]'],
-    'igloo': ['[e-mail]'],
-}
-
 ###############
 # Trend lines #
 ###############
@@ -61,73 +44,108 @@
 ####################################
 # Add extra projects to track here #
 ####################################
-extra_projects = {
     # project      # series to look at, None for all series
-    'igloocommunity': 'trunk',
+# Igloo
+class IglooProjects:
+    notification_addresses = ['[e-mail]']
+    projects = {
+        'igloocommunity': 'trunk',
+     }
 # multimedia
-    'linaro-multimedia-speex': 'trunk',
-    'linaro-multimedia-ucm': 'trunk',
-    'linaro-multimedia-project': 'trunk',
-    'linaro-multimedia-testcontent': 'trunk',
-    'libjpeg-turbo': '1.2',
+class MultimediaProjects:
+    notification_addresses = ['[e-mail]', '[e-mail]']
+    projects = {
+        'linaro-multimedia-speex': 'trunk',
+        'linaro-multimedia-ucm': 'trunk',
+        'linaro-multimedia-project': 'trunk',
+        'linaro-multimedia-testcontent': 'trunk',
+        'libjpeg-turbo': '1.2',
+    }
 # graphics
-    'linaro-graphics-misc': 'trunk',
-    'linaro-graphics-tests': 'trunk',
-    'linaro-graphics-dashboard': 'trunk',
-    'linaro-mm-sig': 'trunk',
-    'unity-gles': 'trunk',
-    'glcompbench': 'trunk',
-    'glmark2': 'trunk',
-    'glmark2-extra': 'trunk',
-    'glproxy': 'trunk',
-    'libmatrix': 'trunk',
-    'smartt': 'trunk',
+class GraphicsProjects:
+    notification_addresses = ['[e-mail]', '[e-mail]']
+    projects = {
+        'linaro-graphics-misc': 'trunk',
+        'linaro-graphics-tests': 'trunk',
+        'linaro-graphics-dashboard': 'trunk',
+        'linaro-mm-sig': 'trunk',
+        'unity-gles': 'trunk',
+        'glcompbench': 'trunk',
+        'glmark2': 'trunk',
+        'glmark2-extra': 'trunk',
+        'glproxy': 'trunk',
+        'libmatrix': 'trunk',
+        'smartt': 'trunk',
+    }
 # toolchain
-    'cortex-strings': 'trunk',
-    'binutils-linaro': 'trunk',
-    'gcc-linaro': '4.6',
-    #'gcc-linaro-tracking': None,
-    'gdb-linaro': '7.3',
-    'qemu-linaro': 'trunk',
-    'cbuild': '11.11',
-    'linaro-toolchain-misc': 'trunk',
-    'linaro-toolchain-benchmarks': 'trunk',
-    'linaro-toolchain-binaries': 'trunk',
-    #'tcwg-web': None,
+class ToolchainProjects:
+    notification_addresses = ['[e-mail]', '[e-mail]']
+    projects = {
+        'cortex-strings': 'trunk',
+        'binutils-linaro': 'trunk',
+        'gcc-linaro': '4.6',
+        'gdb-linaro': '7.3',
+        'qemu-linaro': 'trunk',
+        'cbuild': '11.11',
+        'linaro-toolchain-misc': 'trunk',
+        'linaro-toolchain-benchmarks': 'trunk',
+        'linaro-toolchain-binaries': 'trunk',
+    }
 # kernel
-    'linux-linaro': 'devtrack',
+class KernelProjects:
+    notification_addresses = ['[e-mail]', '[e-mail]']
+    projects = {
+        'linux-linaro': 'devtrack',
+    }
 # power management
-    'linaro-power-kernel': 'trunk',
-    'linaro-power-qa': 'trunk',
-    'linaro-powerdebug': 'trunk',
-    'linaro-powertop': 'trunk',
+class PowerManagementProjects:
+    notification_addresses = ['[e-mail]', '[e-mail]']
+    projects = {
+        'linaro-power-kernel': 'trunk',
+        'linaro-power-qa': 'trunk',
+        'linaro-powerdebug': 'trunk',
+        'linaro-powertop': 'trunk',
+    }
 # dev platform
-    'linaro-ubuntu': 'trunk',
-    'u-boot-linaro': 'trunk',
+class DevPlatformProjects:
+    notification_addresses = ['[e-mail]', '[e-mail]', '[e-mail]', '[e-mail]', '[e-mail]']
+    projects = {
+        'linaro-ubuntu': 'trunk',
+        'u-boot-linaro': 'trunk',
+    }
 # android
-    'linaro-android': 'trunk',
+class AndroidProjects:
+    notification_addresses = ['[e-mail]', '[e-mail]', '[e-mail]', '[e-mail]']
+    projects = {
+        'linaro-android': 'trunk',
+    }
 # validation
-    'lava-android-test': 'trunk',
-    'lava-celery': 'trunk',
-    'lava-dashboard': 'trunk',
-    'lava-dashboard-tool': 'trunk',
-    'lava-dispatcher': 'trunk',
-    'lava-kernel-ci-views': 'trunk',
-    'lava-lab': 'trunk',
-    'lava-qatracker': 'trunk',
-    'lava-scheduler-tool': 'trunk',
-    'lava-scheduler': 'trunk',
-    'lava-server': 'trunk',
-    'lava-test': 'trunk',
-    'lava-tool': 'trunk',
-    'linaro-django-xmlrpc': 'trunk',
-    'linaro-python-dashboard-bundle': 'trunk',
-    'linaro-validation-misc': 'trunk',
+class ValidationProjects:
+    notification_addresses = ['[e-mail]']
+    projects = {
+        'lava-android-test': 'trunk',
+        'lava-celery': 'trunk',
+        'lava-dashboard': 'trunk',
+        'lava-dashboard-tool': 'trunk',
+        'lava-dispatcher': 'trunk',
+        'lava-kernel-ci-views': 'trunk',
+        'lava-lab': 'trunk',
+        'lava-qatracker': 'trunk',
+        'lava-scheduler-tool': 'trunk',
+        'lava-scheduler': 'trunk',
+        'lava-server': 'trunk',
+        'lava-test': 'trunk',
+        'lava-tool': 'trunk',
+        'linaro-django-xmlrpc': 'trunk',
+        'linaro-python-dashboard-bundle': 'trunk',
+        'linaro-validation-misc': 'trunk',
+    }
 # octo
-    'linaro-octo-armhf': 'trunk',
-}
-
-
+class OctoProjects:
+    notification_addresses = ['[e-mail]', '[e-mail]']
+    projects = {
+        'linaro-octo-armhf': 'trunk',
+    }
 ####################################################
 # Infrastructure subprojects fetched directly from #
 # linaro-infrastructure project group.             #
@@ -140,7 +158,21 @@
 for product in data['entries']:
     infra_projects[product['name']] = (
         os.path.basename(product['development_focus_link']))
-extra_projects.update(infra_projects)
+class InfrastructureProjects:
+    notification_addresses = ['[e-mail]', '[e-mail]', '[e-mail]', '[e-mail]']
+    projects = infra_projects
+
+extra_projects = {}
+project_notification_addresses = {}
+
+for klass in (ToolchainProjects, KernelProjects, MultimediaProjects,
+              GraphicsProjects, PowerManagementProjects, DevPlatformProjects,
+              AndroidProjects, ValidationProjects, OctoProjects,
+              InfrastructureProjects, IglooProjects):
+    extra_projects.update(klass.projects)
+    project_notification_addresses.update(dict.fromkeys(
+      klass.projects, klass.notification_addresses))
+project_notification_addresses['linaro'] = ['[e-mail]', '[e-mail]', '[e-mail]', '[e-mail]']
 
 # Ubuntu release to track
 # Linaro probably should not need to track an Ubuntu release /mabac