Code review comment for lp:~maas-maintainers/juju-core/maas-provider-skeleton

Revision history for this message
William Reade (fwereade) wrote :

> Note about points 9 and 17:
>
> «9) environs.HighestVersion in StartInstance [FIX unless not unique]
>
> «This is wrong, but it might still match other providers.»
>
> «17) flags := environs.HighestVersion
>
> «crossgrading (9) to a changing-beyond-recognition»
>
> It's still the same in the EC2 provider, so leaving this be for now.

It'll be a race to land then, still a WIP on my end. If you win, I'm pretty sure it'll be np for me; if I win it should be simple for you but I'm always here to discuss if there are complications.

« Back to merge proposal