Code review comment for lp:~maas-maintainers/juju-core/maas-provider-skeleton

Revision history for this message
William Reade (fwereade) wrote :

> A note on points 10 & 16:
>
> «10) environ.StopInstances([]environs.Instance{&instance})
>
> «Shouldn't this be a release?»
>
> «16) environ.StopInstances([]environs.Instance{&instance})
>
> «upgrading (10) to a FIX»
>
> It may just be me but I have no idea at all what you mean! How is a release
> related to the action of stopping instances? I can't find anything in the
> other providers that might make it clearer either.

Ah, sorry -- I'm saying that if start has failed we should certainly release the nodes back to the pool if we can, but it's confusing to stop something that was never actually started.

« Back to merge proposal