Code review comment for lp:~maas-maintainers/juju-core/maas-provider-skeleton

Revision history for this message
William Reade (fwereade) wrote :

> A note on point 15:
>
> «15) env.ecfgUnlocked = ecfg
>
> «There should be some validation that the two configs match, per thumper's
> branch. If we forgot it elsewhere, which we might have done, don't consider
> this a blocker.»
>
> The preceding call to maasEnvironProvider.newConfig() calls Validate(), which
> in turn will validate the state transition. So that should do the trick,
> right?

I don't think so... ISTM that we would validate against nil, rather than against the old config.

« Back to merge proposal