Code review comment for lp:~maas-maintainers/juju-core/maas-provider-skeleton

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

A note on point 15:

«15) env.ecfgUnlocked = ecfg

«There should be some validation that the two configs match, per thumper's branch. If we forgot it elsewhere, which we might have done, don't consider this a blocker.»

The preceding call to maasEnvironProvider.newConfig() calls Validate(), which in turn will validate the state transition. So that should do the trick, right?

« Back to merge proposal