Code review comment for ~ma-brothier/cloud-init:cs-multi-dhcp

@Marc,

Can you rebase and push --force again ? it looks like you have one failing test. possibly it is just notn completely mocked. i didnt' look much further, but below is how it fails on my system.

$ tox-venv py27 - tests/unittests/test_datasource/test_cloudstack.py
envpython=python2.7
inside tox:py27 running: python -m nose tests/unittests/test_datasource/test_cloudstack.py
.........F...
======================================================================
FAIL: If multiple files match, all should be used.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/smoser-public/src/cloud-init/cloud-init/tests/unittests/test_datasource/test_cloudstack.py", line 173, in test_selects_all_matching
    get_leases(lease_d))
AssertionError: Lists differ: ['/tm[29 chars]lient.leases', '/tmp/ci-TestGetLeases.LS7lQh/d[62 chars]ase'] != ['/tm[29 chars]lient-eth3.lease', '/tmp/ci-TestGetLeases.LS7l[62 chars]ase']

First differing element 0:
/tmp/ci-TestGetLeases.LS7lQh/dhclient.leases
/tmp/ci-TestGetLeases.LS7lQh/dhclient-eth3.lease

- ['/tmp/ci-TestGetLeases.LS7lQh/dhclient.leases',
? -

+ ['/tmp/ci-TestGetLeases.LS7lQh/dhclient-eth3.lease',
? +++++

- '/tmp/ci-TestGetLeases.LS7lQh/dhclient.lease',
+ '/tmp/ci-TestGetLeases.LS7lQh/dhclient.leases',
? +

- '/tmp/ci-TestGetLeases.LS7lQh/dhclient-eth3.lease']
? -----

+ '/tmp/ci-TestGetLeases.LS7lQh/dhclient.lease']
-------------------- >> begin captured logging << --------------------
cloudinit.util: DEBUG: Writing to /tmp/ci-TestGetLeases.LS7lQh/dhclient.leases - wb: [644] 15 bytes
cloudinit.util: DEBUG: Writing to /tmp/ci-TestGetLeases.LS7lQh/dhclient.lease - wb: [644] 14 bytes
cloudinit.util: DEBUG: Writing to /tmp/ci-TestGetLeases.LS7lQh/dhclient.leases - wb: [644] 15 bytes
cloudinit.util: DEBUG: Writing to /tmp/ci-TestGetLeases.LS7lQh/dhclient.lease - wb: [644] 14 bytes
cloudinit.util: DEBUG: Writing to /tmp/ci-TestGetLeases.LS7lQh/dhclient-eth3.lease - wb: [644] 19 bytes
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 13 tests in 0.259s

FAILED (failures=1)