a.) change description to be
Summary
<blank line>
Description
b.) lets go ahead and just keep the function in a net/__init__.py rather than putting it in util. And name it _natural_sort_key(). At some point if someone else needs such a function we can move it to util.
c.) a unit test would be good. Just add something to tests/unittests/test_net.py to test your _natural_key_sort. Also realize you can (and do) get interfaces named 'enp0s25' (as I have on this system).
d.) You'll need to sign the contributors agreement (see HACKING.rst). Please feel free to ping me if you have any questions.
Marc,
This looks good. Some comments... they're all minor, and should be explained more in HACKING.rst cloudinit. readthedocs. io/en/latest/ topics/ hacking. html
http://
a.) change description to be
Summary
<blank line>
Description
b.) lets go ahead and just keep the function in a net/__init__.py rather than putting it in util. And name it _natural_ sort_key( ). At some point if someone else needs such a function we can move it to util.
c.) a unit test would be good. Just add something to tests/unittests /test_net. py to test your _natural_key_sort. Also realize you can (and do) get interfaces named 'enp0s25' (as I have on this system).
d.) You'll need to sign the contributors agreement (see HACKING.rst). Please feel free to ping me if you have any questions.
e.) Thanks!
d.) Thanks!