Code review comment for lp:~m2j/openlp/bug-1094342
Revision history for this message
| Meinert Jordan (m2j) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
> Works on windows and one linux. I tested the sorting only with py2. On py3 I
> only tested if it starts.
>
> I haven't reviewed the code nor did performance tests yet.
Hi, I've looked to the Song class, and realized, that it makes sence to buffer the whole key generation for song titles. This should improve the overall performance (compared to trunk). So just wait for my next code commit.