Code review comment for lp:~lynxman/ubuntu/precise/ipxe/newsnapshot

Revision history for this message
James Page (james-page) wrote :

Hi Mark

Thanks for proposing this merge; here's some feedback

1) I might be missing something but I can't see "Added rules for automatic git branch refresh." in the changes

2) You should really import the new orig.tar.gz into the branch using "bzr merge-upstream"; that way when a sponsor branches and then does bzr bd -S all of the required data including the orig.tar.gz is present in the branch.

3) Please can you apply all patches; at the moment the branch all of them apart from the new patch applied.

Ping me on IRC if you need help with any of the above.

Cheers

James

review: Needs Fixing

« Back to merge proposal