Merge ~lvoytek/ubuntu/+source/ruby-mysql2:restore-datetime-query-test-jammy into ubuntu/+source/ruby-mysql2:ubuntu/jammy-devel

Proposed by Lena Voytek
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merged at revision: 65b350df9e858c793895c2d7319696665afde939
Proposed branch: ~lvoytek/ubuntu/+source/ruby-mysql2:restore-datetime-query-test-jammy
Merge into: ubuntu/+source/ruby-mysql2:ubuntu/jammy-devel
Diff against target: 68 lines (+8/-38)
3 files modified
debian/changelog (+8/-0)
debian/patches/series (+0/-1)
dev/null (+0/-37)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Lucas Kanashiro (community) Approve
Canonical Server Reporter Pending
Review via email: mp+426650@code.launchpad.net

Description of the change

Reverting autopkgtest patch for datetime and time since the changed behavior was fixed in mysql 8.0.29. This was fixed in kinetic in 0.5.3-3ubuntu5.

PPA: ppa:lvoytek/ruby-mysql2-revert-datetime-test-change-jammy

To post a comment you must log in.
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for the MP Lena. I added an inline comment about the changelog entry. Other than that, everything LGTM.

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: lucaskanashiro, lvoytek
Uploaders: lucaskanashiro
MP auto-approved

review: Approve
Revision history for this message
Lena Voytek (lvoytek) wrote :

updated, thanks!

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Lena, I'll be waiting for the SRU bug template to sponsor this upload for you. Let me know once it is ready.

Revision history for this message
Lena Voytek (lvoytek) wrote :

Alright, I added in the SRU template to the bug report. Thanks for sponsoring

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Package uploaded:

Uploading ruby-mysql2_0.5.3-3ubuntu4.22.04.1.dsc
Uploading ruby-mysql2_0.5.3.orig.tar.gz
Uploading ruby-mysql2_0.5.3-3ubuntu4.22.04.1.debian.tar.xz
Uploading ruby-mysql2_0.5.3-3ubuntu4.22.04.1_source.buildinfo
Uploading ruby-mysql2_0.5.3-3ubuntu4.22.04.1_source.changes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 9ba329a..b5c9f06 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
1ruby-mysql2 (0.5.3-3ubuntu4.22.04.1) jammy; urgency=medium
2
3 * d/p/adjust-test-acc-to-mysql-8.0.28-change.patch: Remove file to restore
4 original test setup since functionality was fixed for Time and
5 DateTime query's with 'SELECT ?' in mysql 8.0.29 (LP: #1981343)
6
7 -- Lena Voytek <lena.voytek@canonical.com> Mon, 11 Jul 2022 08:49:58 -0700
8
1ruby-mysql2 (0.5.3-3ubuntu4) jammy; urgency=medium9ruby-mysql2 (0.5.3-3ubuntu4) jammy; urgency=medium
210
3 * d/p/adjust-test-acc-to-mysql-8.0.28-change.patch:11 * d/p/adjust-test-acc-to-mysql-8.0.28-change.patch:
diff --git a/debian/patches/adjust-test-acc-to-mysql-8.0.28-change.patch b/debian/patches/adjust-test-acc-to-mysql-8.0.28-change.patch
4deleted file mode 10064412deleted file mode 100644
index c1dea77..0000000
--- a/debian/patches/adjust-test-acc-to-mysql-8.0.28-change.patch
+++ /dev/null
@@ -1,37 +0,0 @@
1Description: Adjust tests according to mysql-8.0/8.0.28
2 behavioral change. MySQL now returns a String instead
3 of a DateTime object when called with "SELECT ? AS a"
4 and a parameter of MYSQL_TYPE_DATETIME.
5Author: Utkarsh Gupta <utkarsh@ubuntu.com>
6Origin: vendor
7Bug: https://github.com/brianmario/mysql2/issues/1243
8Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/mysql-8.0/+bug/1961617
9Forwarded: https://github.com/brianmario/mysql2/issues/1243
10Last-Update: 2022-02-23
11
12--- a/spec/mysql2/statement_spec.rb
13+++ b/spec/mysql2/statement_spec.rb
14@@ -1,4 +1,5 @@
15 require './spec/spec_helper.rb'
16+require 'time'
17
18 RSpec.describe Mysql2::Statement do
19 before :each do
20@@ -165,7 +166,7 @@
21 statement = @client.prepare('SELECT ? AS a')
22 result = statement.execute(now)
23 # microseconds is six digits after the decimal, but only test on 5 significant figures
24- expect(result.first['a'].strftime('%F %T.%5N %z')).to eql(now.strftime('%F %T.%5N %z'))
25+ expect(Time.parse(result.first['a']).strftime('%F %T.%5N %z')).to eql(now.strftime('%F %T.%5N %z'))
26 end
27
28 it "should prepare DateTime values with microseconds" do
29@@ -173,7 +174,7 @@
30 statement = @client.prepare('SELECT ? AS a')
31 result = statement.execute(now)
32 # microseconds is six digits after the decimal, but only test on 5 significant figures
33- expect(result.first['a'].strftime('%F %T.%5N %z')).to eql(now.strftime('%F %T.%5N %z'))
34+ expect(Time.parse(result.first['a']).strftime('%F %T.%5N %z')).to eql(now.strftime('%F %T.%5N %z'))
35 end
36
37 it "should tell us about the fields" do
diff --git a/debian/patches/series b/debian/patches/series
index b9702e0..11094cb 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -7,4 +7,3 @@ mysql-8.0.patch
7skip-more-tests.patch7skip-more-tests.patch
8fix-configuration.patch8fix-configuration.patch
9skip-test-that-depends-on-server.patch9skip-test-that-depends-on-server.patch
10adjust-test-acc-to-mysql-8.0.28-change.patch

Subscribers

People subscribed via source and target branches