Code review comment for ~lvoytek/ubuntu/+source/python-django:merge-lp1946890-jammy

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

@Utkarsh
The conflicts come from the merge target being ubuntu/devel, but since this is meant to show the (non-)delta to Debian it would need to be against debian/sid to show correctly.

@utkarsh
By accident you've consumed the canonical-server slot which is needed to be seen in our overviews, I can't add one back, but since I'll approve that is ok. Otherwise we'd need to add it back now.

--- review --

Vs the right branch it LGTM

$ git diff pkg/debian/sid | diffstat
 changelog | 14 ++++++++++++++
 control | 3 ++-
 2 files changed, 16 insertions(+), 1 deletion(-)

Sure, the question now is were all drops correct, but there is only one and plenty of tests 8as discussed in standup yesterday).

5030e5d8a * d/p/test_subparser_regression.patch: Fix test regression (LP: #1945993)
Is in 3.2.8 so it is ok to drop it.
No other delta left.

The tests indeed passed and I looked at $ lp-test-ppa ppa:lvoytek/python-django-sync-jammy --release jammy --showpass which showed me all the others that passed just fine.

On the Debian side a lot has changed since 2.2.24 (two years !)
Really time to get this updated.
The migration might have some hiccups due to that, but I see no show stoppers in there that would not work well for Ubuntu.

Therefore +1 to sync this.

review: Approve

« Back to merge proposal