Ubuntu
python-django-modelcluster package

Code review comment for ~lvoytek/ubuntu/+source/python-django-modelcluster:fix-django4-compatibility

  1. Git
  2. lp:~lvoytek/ubuntu/+source/python-django-modelcluster
  3. fix-django4-compatibility
  4. Merge into ubuntu/devel
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for referring to this PR. I just tried to apply part of the changes in that PR (changes inside the test/ directory only) and they still work fine with Django 3.2 in the archive, and I assume it should work with Django 4.2 from your PPA as well. Could you please try that out?

I understand it was not merged upstream yet but the changes look reasonable to me. I think we should at least try to follow that, in this case we can use the proposed patch with some modifications. Moreover, the patch seems to also make sure the tests pass with Django master branch (>= 5.0), so this can avoid a similar issue when we perform the next transition. WDYT?

« Back to merge proposal