Merge ~lvoytek/ubuntu/+source/mysql-8.0:lp1980466-fix-mysql_secure_installation-kinetic into ubuntu/+source/mysql-8.0:ubuntu/kinetic-devel

[Lena Voytek]

Fix mysql_secure_installation in Kinetic

The changes here are exactly the same as those in lunar and mantic.
The mantic mp is here: https://code.launchpad.net/~lvoytek/ubuntu/+source/mysql-8.0/+git/mysql-8.0/+merge/442678
The lunar mp is here, the diff is messy though since it was compared against ubuntu/devel: https://code.launchpad.net/~lvoytek/ubuntu/+source/mysql-8.0/+git/mysql-8.0/+merge/440515

PPA: https://launchpad.net/~lvoytek/+archive/ubuntu/mysql-mysql-secure-installation

Testing:

# lxc launch ubuntu:kinetic test-kinetic
# lxc exec test-kinetic bash
# apt update && apt dist-upgrade -y
# add-apt-repository ppa:lvoytek/mysql-mysql-secure-installation
# apt install mysql-server -y
# mysql_secure_installation

[Lena Voytek (lvoytek)]

Uploaded:

dput ubuntu ../mysql-8.0_8.0.33-0ubuntu0.22.10.3_source.changes
D: Setting host argument.
Checking signature on .changes
gpg: ../mysql-8.0_8.0.33-0ubuntu0.22.10.3_source.changes: Valid signature from 34B8AD7D9529E793
Checking signature on .dsc
gpg: ../mysql-8.0_8.0.33-0ubuntu0.22.10.3.dsc: Valid signature from 34B8AD7D9529E793
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading mysql-8.0_8.0.33-0ubuntu0.22.10.3.dsc: done.
  Uploading mysql-8.0_8.0.33-0ubuntu0.22.10.3.debian.tar.xz: done.
  Uploading mysql-8.0_8.0.33-0ubuntu0.22.10.3_source.buildinfo: done.
  Uploading mysql-8.0_8.0.33-0ubuntu0.22.10.3_source.changes: done.
Successfully uploaded packages.

review: Approve

diff --git a/debian/changelog b/debian/changelog
index 23612c7..21bd02a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+mysql-8.0 (8.0.33-0ubuntu0.22.10.3) kinetic; urgency=medium
+
+  * d/p/mysql_secure_installation-remove-root-pw-creation.patch: Fix
+    mysql_secure_installation by removing root password creation (LP: #1980466)
+
+ -- Lena Voytek <[e-mail]>  Thu, 08 Jun 2023 07:35:13 -0700
+
 mysql-8.0 (8.0.33-0ubuntu0.22.10.2) kinetic-security; urgency=medium
 
   * Fix crash on startup on armhf (LP: #2019203)
diff --git a/debian/patches/mysql_secure_installation-remove-root-pw-creation.patch b/debian/patches/mysql_secure_installation-remove-root-pw-creation.patch
new file mode 100644
index 0000000..22bc248
--- /dev/null
+++ b/debian/patches/mysql_secure_installation-remove-root-pw-creation.patch
@@ -0,0 +1,30 @@
+Description: Remove the creation of a root password in mysql_secure_installation
+ Since Ubuntu and Debian use the auth_socket plugin for the root user by default,
+ and attempting to set a password for it through "SET_PASSWORD" causes an error,
+ do not create a root password in the mysql_secure_installation script if one
+ has not been set previously. If the user would like to instead use a password
+ they can run
+ ALTER USER 'root'@'localhost' IDENTIFIED WITH mysql_native_password by 'password';
+ in the mysql client.
+Author: Lena Voytek <[e-mail]>
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/mysql-8.0/+bug/1980466
+Forwarded: no
+Last-Update: 2023-04-20
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/client/mysql_secure_installation.cc
++++ b/client/mysql_secure_installation.cc
+@@ -811,8 +811,11 @@
+   }
+ 
+   if (!hadpass) {
+-    fprintf(stdout, "Please set the password for %s here.\n", opt_user);
+-    set_opt_user_password(component_set);
++    fprintf(stdout,
++            "\nSkipping password set for %s as authentication with auth_socket is used by default.\n"
++            "If you would like to use password authentication instead, this can be done with the \"ALTER_USER\" command.\n"
++            "See https://dev.mysql.com/doc/refman/8.0/en/alter-user.html#alter-user-password-management for more information.\n\n"
++            , opt_user);
+   } else if (opt_use_default == false) {
+     char prompt[256];
+     fprintf(stdout, "Using existing password for %s.\n", opt_user);
diff --git a/debian/patches/series b/debian/patches/series
index f36ae9f..dab82cf 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -9,3 +9,4 @@ boost-1.76.0-fix_multiprecision_issue_419-ppc64le.patch
 disable_timestamping_test.patch
 revert-be8348a7.patch
 fix_expired_date_in_test.patch
+mysql_secure_installation-remove-root-pw-creation.patch