Merge ~lvoytek/ubuntu/+source/mysql-8.0:lp1980466-fix-mysql_secure_installation-mantic into ubuntu/+source/mysql-8.0:ubuntu/devel

[Lena Voytek]

Adding mysql_secure_installation fix to mantic

PPA: https://launchpad.net/~lvoytek/+archive/ubuntu/mysql-mysql-secure-installation

Lunar mp (will reupload since security team superseded it): https://code.launchpad.net/~lvoytek/ubuntu/+source/mysql-8.0/+git/mysql-8.0/+merge/440515

635018f... by Marc Deslauriers on 2023-05-11

8.0.33-0ubuntu3 (patches unapplied)

Imported using git-ubuntu import.

[Miriam España Acebal (mirespace)]

LGTM Lena! Same as Lunar :)

review: Approve

[git-ubuntu bot (git-ubuntu-bot)]

Approvers: lvoytek, mirespace
Uploaders: lvoytek
MP auto-approved

review: Approve

c7140ff... by Lena Voytek on 2023-05-15

changelog

[Lena Voytek (lvoytek)]

Thanks for the review Miriam! Updated and uploaded:

dput ubuntu ../mysql-8.0_8.0.33-0ubuntu4_source.changes
D: Setting host argument.
Checking signature on .changes
gpg: ../mysql-8.0_8.0.33-0ubuntu4_source.changes: Valid signature from 34B8AD7D9529E793
Checking signature on .dsc
gpg: ../mysql-8.0_8.0.33-0ubuntu4.dsc: Valid signature from 34B8AD7D9529E793
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading mysql-8.0_8.0.33-0ubuntu4.dsc: done.
  Uploading mysql-8.0_8.0.33-0ubuntu4.debian.tar.xz: done.
  Uploading mysql-8.0_8.0.33-0ubuntu4_source.buildinfo: done.
  Uploading mysql-8.0_8.0.33-0ubuntu4_source.changes: done.
Successfully uploaded packages.

diff --git a/debian/changelog b/debian/changelog
index a1641cf..e5a5324 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+mysql-8.0 (8.0.33-0ubuntu4) mantic; urgency=medium
+
+  * d/p/mysql_secure_installation-remove-root-pw-creation.patch: Fix
+    mysql_secure_installation by removing root password creation (LP: #1980466)
+
+ -- Lena Voytek <[e-mail]>  Mon, 15 May 2023 08:52:09 -0700
+
 mysql-8.0 (8.0.33-0ubuntu3) mantic; urgency=medium
 
   * Fix crash on startup on armhf (LP: #2019203)
diff --git a/debian/patches/mysql_secure_installation-remove-root-pw-creation.patch b/debian/patches/mysql_secure_installation-remove-root-pw-creation.patch
new file mode 100644
index 0000000..22bc248
--- /dev/null
+++ b/debian/patches/mysql_secure_installation-remove-root-pw-creation.patch
@@ -0,0 +1,30 @@
+Description: Remove the creation of a root password in mysql_secure_installation
+ Since Ubuntu and Debian use the auth_socket plugin for the root user by default,
+ and attempting to set a password for it through "SET_PASSWORD" causes an error,
+ do not create a root password in the mysql_secure_installation script if one
+ has not been set previously. If the user would like to instead use a password
+ they can run
+ ALTER USER 'root'@'localhost' IDENTIFIED WITH mysql_native_password by 'password';
+ in the mysql client.
+Author: Lena Voytek <[e-mail]>
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/mysql-8.0/+bug/1980466
+Forwarded: no
+Last-Update: 2023-04-20
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/client/mysql_secure_installation.cc
++++ b/client/mysql_secure_installation.cc
+@@ -811,8 +811,11 @@
+   }
+ 
+   if (!hadpass) {
+-    fprintf(stdout, "Please set the password for %s here.\n", opt_user);
+-    set_opt_user_password(component_set);
++    fprintf(stdout,
++            "\nSkipping password set for %s as authentication with auth_socket is used by default.\n"
++            "If you would like to use password authentication instead, this can be done with the \"ALTER_USER\" command.\n"
++            "See https://dev.mysql.com/doc/refman/8.0/en/alter-user.html#alter-user-password-management for more information.\n\n"
++            , opt_user);
+   } else if (opt_use_default == false) {
+     char prompt[256];
+     fprintf(stdout, "Using existing password for %s.\n", opt_user);
diff --git a/debian/patches/series b/debian/patches/series
index f36ae9f..dab82cf 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -9,3 +9,4 @@ boost-1.76.0-fix_multiprecision_issue_419-ppc64le.patch
 disable_timestamping_test.patch
 revert-be8348a7.patch
 fix_expired_date_in_test.patch
+mysql_secure_installation-remove-root-pw-creation.patch