Code review comment for ~lvoytek/ubuntu/+source/mysql-8.0:mysql-lp1899248-increase-shutdown-timeout-sru-focal

Revision history for this message
Bryce Harrington (bryce) wrote :

Oh, one other remark, a question I'm sure will come up in SRU review will be, "What causes the long installation times that are triggering the timeout?" In particular, they're going to be wondering if increasing the timeout is going to result in a successful installation or not.

For example, if there's evidence proving it to be resource limitations (especially if the conditions can be replicated synthetically), that would give a very solid rationale. Otherwise, the explanation should say "our suspicion is the delay is caused by ..." and point to the clues collected so far.

Btw, sorry for so much feedback on this MP; in truth the timeout change is probably a no-brainer. However, the general process outlined here for identifying and justifying the changes will be of value to follow for other mysql fixes you'll develop in the future. Getting the paperwork process into good practice will make SRU filing go smoothly. With larger packages like mysql, where there may sometimes be multiple SRUs in flight, being organized will pay off.

« Back to merge proposal