Code review comment for ~lvoytek/ubuntu/+source/munin:merge-lp1986980-kinetic

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This split is incorrect:

commit 1c1d8bc9d4bfb02554b827cd89e8b81e8e6bb793
Author: Lena Voytek <email address hidden>
Date: Thu Aug 18 09:09:51 2022 -0700

    * Stop cron and clean cache before running tests, because cron can also run
      munin

It has in it other changes:
- munin-async.postinst: seems to be "run the setup again, if upgrading from 2.0.37-1"
- d/t/control: seems to be "disable sysv autopkgtests", an added change from a previous merge in groovy

For this split, I think you only want the debian/tests/master-cgi-systemd bit

This commit in split also seems wrong:
commit 30b550c0228789632023ab8154ea448cc37d1408
Author: Lena Voytek <email address hidden>
Date: Thu Aug 18 09:07:23 2022 -0700

    * Add missing test dependency on net-tools for netstat plugin.

As it's also disabling the node-sysv test. That change seems to be part of the "disable sysv autopkgtests" added delta, and should be in that commit.

Feel free to adjust the commit messages to include the files it touched, it will make future merges much easier and cleaner.

review: Needs Fixing

« Back to merge proposal