Code review comment for ~lvoytek/ubuntu/+source/munin:munin-node-configure-lp1680975-doc-fix-jammy

Revision history for this message
Lena Voytek (lvoytek) wrote (last edit ):

> Thanks for the MP, Lena.
>
> I'm leaving a few inline comments, but overall it LGTM. A question: have you
> considered forwarding this patch to the Debian munin package? I don't have a
> problem with carrying this as a delta temporarily, but ultimately Debian could
> also benefit from this and we'd get rid of the maintenance burden.
>
> I haven't built/tested the package yet, FWIW.
>
> Thanks.

Alright, I updated the code with your comments in mind. Hopefully the added comment on the patch file describes what is happening well enough. I can update it or the author/origin fields if needed though.

I'll get started on proposing this merge in Debian too.
Thanks!

« Back to merge proposal