Ubuntu
lua5.4 package

Merge ~lvoytek/ubuntu/+source/lua5.4:mantic-mir-packaging-cleanup into ubuntu/+source/lua5.4:ubuntu/devel

  1. Git
  2. lp:~lvoytek/ubuntu/+source/lua5.4
  3. mantic-mir-packaging-cleanup
  4. Merge into ubuntu/devel
Proposed by Lena Voytek
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merged at revision: a626bc55b061a31718bfe55521faaa4dff6c56d0
Proposed branch: ~lvoytek/ubuntu/+source/lua5.4:mantic-mir-packaging-cleanup
Merge into: ubuntu/+source/lua5.4:ubuntu/devel
Diff against target: 343 lines (+318/-1)
3 files modified
debian/changelog (+10/-0)
debian/configure.ac (+0/-1)
debian/liblua5.4-0.symbols (+308/-0)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Andreas Hasenack Approve
Canonical Server Reporter Pending
Review via email: mp+447936@code.launchpad.net

Description of the change

Add some additional cleanup to lua5.4 for the MIR.
- Add symbols file
- Fix build time deprecation warning

PPA: https://launchpad.net/~lvoytek/+archive/ubuntu/lua-mir-update

autopkgtest results:
  lua5.4 @ amd64:
    27.07.23 19:07:18 Log 🗒️ ✅ Triggers: lua5.4/5.4.6-0ubuntu2~ppa8
  lua5.4 @ arm64:
    27.07.23 19:59:02 Log 🗒️ ✅ Triggers: lua5.4/5.4.6-0ubuntu2~ppa8
  lua5.4 @ armhf:
    27.07.23 19:09:45 Log 🗒️ ✅ Triggers: lua5.4/5.4.6-0ubuntu2~ppa8
  lua5.4 @ ppc64el:
    27.07.23 19:13:08 Log 🗒️ ✅ Triggers: lua5.4/5.4.6-0ubuntu2~ppa8

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Grabbing this since I reviewed the previous lua MP.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Since you are adding the symbols file, maybe handle this lintian warning for it?
I: liblua5.4-0: symbols-file-missing-build-depends-package-field liblua5.4-c++.so.0 [symbols]
I: liblua5.4-0: symbols-file-missing-build-depends-package-field liblua5.4.so.0 [symbols]

If I understood it correctly, this should do it:
--- a/debian/liblua5.4-0.symbols
+++ b/debian/liblua5.4-0.symbols
@@ -1,4 +1,5 @@
 liblua5.4-c++.so.0 liblua5.4-0 #MINVER#
+* Build-Depends-Package: liblua5.4-dev
  LUA_5.4@LUA_5.4 5.4.6
  luaL_addlstring@LUA_5.4 5.4.6
  luaL_addstring@LUA_5.4 5.4.6
@@ -152,6 +153,7 @@ liblua5.4-c++.so.0 liblua5.4-0 #MINVER#
  luaopen_table@LUA_5.4 5.4.6
  luaopen_utf8@LUA_5.4 5.4.6
 liblua5.4.so.0 liblua5.4-0 #MINVER#
+* Build-Depends-Package: liblua5.4-dev
  LUA_5.4@LUA_5.4 5.4.6
  luaL_addlstring@LUA_5.4 5.4.6
  luaL_addstring@LUA_5.4 5.4.6

I see there are c++ symbols, but none of the madness we saw in symbols other packages with c++ libraries, not sure why, but this seems correct. I tried a few builds by manually adding and removing symbols, and dpkg-gensymbols gave the correct warnings.

+1

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: ahasenack, lvoytek
Uploaders: ahasenack
MP auto-approved

review: Approve
Revision history for this message
Lena Voytek (lvoytek) wrote :

Thanks for the help with that! The lines fix up the lintian info items so I've added them in. Would you be willing to sponsor this upload too since lua5.4 isn't in the server package set yet?

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Ah, sure

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Uploaded with rich history:

Uploading lua5.4_5.4.6-0ubuntu2.dsc
Uploading lua5.4_5.4.6-0ubuntu2.debian.tar.xz
Uploading lua5.4_5.4.6-0ubuntu2_source.buildinfo
Uploading lua5.4_5.4.6-0ubuntu2_source.changes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 1949954..b62101f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
1lua5.4 (5.4.6-0ubuntu2) mantic; urgency=medium
2
3 * Improve packaging in preparation for MIR (LP: #2028695)
4 - d/configure.ac: Remove AC_PROG_LIBTOOL entry
5 AC_PROG_LIBTOOL is a deprecated macro for initializing libtool. LT_INIT
6 already covers this functionality so no other action is required.
7 - d/liblua5.4-0.symbols: Add symbols file for lua 5.4 libraries
8
9 -- Lena Voytek <lena.voytek@canonical.com> Wed, 26 Jul 2023 11:31:06 -0700
10
1lua5.4 (5.4.6-0ubuntu1) mantic; urgency=medium11lua5.4 (5.4.6-0ubuntu1) mantic; urgency=medium
212
3 * New upstream release 5.4.6 (LP: #2028192)13 * New upstream release 5.4.6 (LP: #2028192)
diff --git a/debian/configure.ac b/debian/configure.ac
index 75addc0..ae47196 100644
--- a/debian/configure.ac
+++ b/debian/configure.ac
@@ -1,6 +1,5 @@
1AC_INIT([dummy],[1.0])1AC_INIT([dummy],[1.0])
2LT_INIT2LT_INIT
3AC_PROG_LIBTOOL
4AC_PROG_CC3AC_PROG_CC
5AC_PROG_CXX4AC_PROG_CXX
6AC_OUTPUT5AC_OUTPUT
diff --git a/debian/liblua5.4-0.symbols b/debian/liblua5.4-0.symbols
7new file mode 1006446new file mode 100644
index 0000000..12b37d3
--- /dev/null
+++ b/debian/liblua5.4-0.symbols
@@ -0,0 +1,308 @@
1liblua5.4-c++.so.0 liblua5.4-0 #MINVER#
2* Build-Depends-Package: liblua5.4-dev
3 LUA_5.4@LUA_5.4 5.4.6
4 luaL_addlstring@LUA_5.4 5.4.6
5 luaL_addstring@LUA_5.4 5.4.6
6 luaL_addvalue@LUA_5.4 5.4.6
7 luaL_argerror@LUA_5.4 5.4.6
8 luaL_buffinit@LUA_5.4 5.4.6
9 luaL_buffinitsize@LUA_5.4 5.4.6
10 luaL_callmeta@LUA_5.4 5.4.6
11 luaL_checkany@LUA_5.4 5.4.6
12 luaL_checkinteger@LUA_5.4 5.4.6
13 luaL_checklstring@LUA_5.4 5.4.6
14 luaL_checknumber@LUA_5.4 5.4.6
15 luaL_checkoption@LUA_5.4 5.4.6
16 luaL_checkstack@LUA_5.4 5.4.6
17 luaL_checktype@LUA_5.4 5.4.6
18 luaL_checkudata@LUA_5.4 5.4.6
19 luaL_checkversion_@LUA_5.4 5.4.6
20 luaL_error@LUA_5.4 5.4.6
21 luaL_execresult@LUA_5.4 5.4.6
22 luaL_fileresult@LUA_5.4 5.4.6
23 luaL_getmetafield@LUA_5.4 5.4.6
24 luaL_getsubtable@LUA_5.4 5.4.6
25 luaL_gsub@LUA_5.4 5.4.6
26 luaL_len@LUA_5.4 5.4.6
27 luaL_loadbufferx@LUA_5.4 5.4.6
28 luaL_loadfilex@LUA_5.4 5.4.6
29 luaL_loadstring@LUA_5.4 5.4.6
30 luaL_newmetatable@LUA_5.4 5.4.6
31 luaL_newstate@LUA_5.4 5.4.6
32 luaL_openlibs@LUA_5.4 5.4.6
33 luaL_optinteger@LUA_5.4 5.4.6
34 luaL_optlstring@LUA_5.4 5.4.6
35 luaL_optnumber@LUA_5.4 5.4.6
36 luaL_prepbuffsize@LUA_5.4 5.4.6
37 luaL_pushresult@LUA_5.4 5.4.6
38 luaL_pushresultsize@LUA_5.4 5.4.6
39 luaL_ref@LUA_5.4 5.4.6
40 luaL_requiref@LUA_5.4 5.4.6
41 luaL_setfuncs@LUA_5.4 5.4.6
42 luaL_setmetatable@LUA_5.4 5.4.6
43 luaL_testudata@LUA_5.4 5.4.6
44 luaL_tolstring@LUA_5.4 5.4.6
45 luaL_traceback@LUA_5.4 5.4.6
46 luaL_typeerror@LUA_5.4 5.4.6
47 luaL_unref@LUA_5.4 5.4.6
48 luaL_where@LUA_5.4 5.4.6
49 lua_absindex@LUA_5.4 5.4.6
50 lua_arith@LUA_5.4 5.4.6
51 lua_atpanic@LUA_5.4 5.4.6
52 lua_callk@LUA_5.4 5.4.6
53 lua_checkstack@LUA_5.4 5.4.6
54 lua_close@LUA_5.4 5.4.6
55 lua_compare@LUA_5.4 5.4.6
56 lua_concat@LUA_5.4 5.4.6
57 lua_copy@LUA_5.4 5.4.6
58 lua_createtable@LUA_5.4 5.4.6
59 lua_dump@LUA_5.4 5.4.6
60 lua_error@LUA_5.4 5.4.6
61 lua_gc@LUA_5.4 5.4.6
62 lua_getallocf@LUA_5.4 5.4.6
63 lua_getfield@LUA_5.4 5.4.6
64 lua_getglobal@LUA_5.4 5.4.6
65 lua_gethook@LUA_5.4 5.4.6
66 lua_gethookcount@LUA_5.4 5.4.6
67 lua_gethookmask@LUA_5.4 5.4.6
68 lua_geti@LUA_5.4 5.4.6
69 lua_getinfo@LUA_5.4 5.4.6
70 lua_getiuservalue@LUA_5.4 5.4.6
71 lua_getlocal@LUA_5.4 5.4.6
72 lua_getmetatable@LUA_5.4 5.4.6
73 lua_getstack@LUA_5.4 5.4.6
74 lua_gettable@LUA_5.4 5.4.6
75 lua_gettop@LUA_5.4 5.4.6
76 lua_getupvalue@LUA_5.4 5.4.6
77 lua_ident@LUA_5.4 5.4.6
78 lua_iscfunction@LUA_5.4 5.4.6
79 lua_isinteger@LUA_5.4 5.4.6
80 lua_isnumber@LUA_5.4 5.4.6
81 lua_isstring@LUA_5.4 5.4.6
82 lua_isuserdata@LUA_5.4 5.4.6
83 lua_isyieldable@LUA_5.4 5.4.6
84 lua_len@LUA_5.4 5.4.6
85 lua_load@LUA_5.4 5.4.6
86 lua_newstate@LUA_5.4 5.4.6
87 lua_newthread@LUA_5.4 5.4.6
88 lua_newuserdatauv@LUA_5.4 5.4.6
89 lua_next@LUA_5.4 5.4.6
90 lua_pcallk@LUA_5.4 5.4.6
91 lua_pushboolean@LUA_5.4 5.4.6
92 lua_pushcclosure@LUA_5.4 5.4.6
93 lua_pushfstring@LUA_5.4 5.4.6
94 lua_pushinteger@LUA_5.4 5.4.6
95 lua_pushlightuserdata@LUA_5.4 5.4.6
96 lua_pushlstring@LUA_5.4 5.4.6
97 lua_pushnil@LUA_5.4 5.4.6
98 lua_pushnumber@LUA_5.4 5.4.6
99 lua_pushstring@LUA_5.4 5.4.6
100 lua_pushthread@LUA_5.4 5.4.6
101 lua_pushvalue@LUA_5.4 5.4.6
102 lua_pushvfstring@LUA_5.4 5.4.6
103 lua_rawequal@LUA_5.4 5.4.6
104 lua_rawget@LUA_5.4 5.4.6
105 lua_rawgeti@LUA_5.4 5.4.6
106 lua_rawgetp@LUA_5.4 5.4.6
107 lua_rawlen@LUA_5.4 5.4.6
108 lua_rawset@LUA_5.4 5.4.6
109 lua_rawseti@LUA_5.4 5.4.6
110 lua_rawsetp@LUA_5.4 5.4.6
111 lua_resetthread@LUA_5.4 5.4.6
112 lua_resume@LUA_5.4 5.4.6
113 lua_rotate@LUA_5.4 5.4.6
114 lua_setallocf@LUA_5.4 5.4.6
115 lua_setfield@LUA_5.4 5.4.6
116 lua_setglobal@LUA_5.4 5.4.6
117 lua_sethook@LUA_5.4 5.4.6
118 lua_seti@LUA_5.4 5.4.6
119 lua_setiuservalue@LUA_5.4 5.4.6
120 lua_setlocal@LUA_5.4 5.4.6
121 lua_setmetatable@LUA_5.4 5.4.6
122 lua_settable@LUA_5.4 5.4.6
123 lua_settop@LUA_5.4 5.4.6
124 lua_setupvalue@LUA_5.4 5.4.6
125 lua_setwarnf@LUA_5.4 5.4.6
126 lua_status@LUA_5.4 5.4.6
127 lua_stringtonumber@LUA_5.4 5.4.6
128 lua_toboolean@LUA_5.4 5.4.6
129 lua_tocfunction@LUA_5.4 5.4.6
130 lua_toclose@LUA_5.4 5.4.6
131 lua_tointegerx@LUA_5.4 5.4.6
132 lua_tolstring@LUA_5.4 5.4.6
133 lua_tonumberx@LUA_5.4 5.4.6
134 lua_topointer@LUA_5.4 5.4.6
135 lua_tothread@LUA_5.4 5.4.6
136 lua_touserdata@LUA_5.4 5.4.6
137 lua_type@LUA_5.4 5.4.6
138 lua_typename@LUA_5.4 5.4.6
139 lua_upvalueid@LUA_5.4 5.4.6
140 lua_upvaluejoin@LUA_5.4 5.4.6
141 lua_version@LUA_5.4 5.4.6
142 lua_warning@LUA_5.4 5.4.6
143 lua_xmove@LUA_5.4 5.4.6
144 lua_yieldk@LUA_5.4 5.4.6
145 luaopen_base@LUA_5.4 5.4.6
146 luaopen_coroutine@LUA_5.4 5.4.6
147 luaopen_debug@LUA_5.4 5.4.6
148 luaopen_io@LUA_5.4 5.4.6
149 luaopen_math@LUA_5.4 5.4.6
150 luaopen_os@LUA_5.4 5.4.6
151 luaopen_package@LUA_5.4 5.4.6
152 luaopen_string@LUA_5.4 5.4.6
153 luaopen_table@LUA_5.4 5.4.6
154 luaopen_utf8@LUA_5.4 5.4.6
155liblua5.4.so.0 liblua5.4-0 #MINVER#
156* Build-Depends-Package: liblua5.4-dev
157 LUA_5.4@LUA_5.4 5.4.6
158 luaL_addlstring@LUA_5.4 5.4.6
159 luaL_addstring@LUA_5.4 5.4.6
160 luaL_addvalue@LUA_5.4 5.4.6
161 luaL_argerror@LUA_5.4 5.4.6
162 luaL_buffinit@LUA_5.4 5.4.6
163 luaL_buffinitsize@LUA_5.4 5.4.6
164 luaL_callmeta@LUA_5.4 5.4.6
165 luaL_checkany@LUA_5.4 5.4.6
166 luaL_checkinteger@LUA_5.4 5.4.6
167 luaL_checklstring@LUA_5.4 5.4.6
168 luaL_checknumber@LUA_5.4 5.4.6
169 luaL_checkoption@LUA_5.4 5.4.6
170 luaL_checkstack@LUA_5.4 5.4.6
171 luaL_checktype@LUA_5.4 5.4.6
172 luaL_checkudata@LUA_5.4 5.4.6
173 luaL_checkversion_@LUA_5.4 5.4.6
174 luaL_error@LUA_5.4 5.4.6
175 luaL_execresult@LUA_5.4 5.4.6
176 luaL_fileresult@LUA_5.4 5.4.6
177 luaL_getmetafield@LUA_5.4 5.4.6
178 luaL_getsubtable@LUA_5.4 5.4.6
179 luaL_gsub@LUA_5.4 5.4.6
180 luaL_len@LUA_5.4 5.4.6
181 luaL_loadbufferx@LUA_5.4 5.4.6
182 luaL_loadfilex@LUA_5.4 5.4.6
183 luaL_loadstring@LUA_5.4 5.4.6
184 luaL_newmetatable@LUA_5.4 5.4.6
185 luaL_newstate@LUA_5.4 5.4.6
186 luaL_openlibs@LUA_5.4 5.4.6
187 luaL_optinteger@LUA_5.4 5.4.6
188 luaL_optlstring@LUA_5.4 5.4.6
189 luaL_optnumber@LUA_5.4 5.4.6
190 luaL_prepbuffsize@LUA_5.4 5.4.6
191 luaL_pushresult@LUA_5.4 5.4.6
192 luaL_pushresultsize@LUA_5.4 5.4.6
193 luaL_ref@LUA_5.4 5.4.6
194 luaL_requiref@LUA_5.4 5.4.6
195 luaL_setfuncs@LUA_5.4 5.4.6
196 luaL_setmetatable@LUA_5.4 5.4.6
197 luaL_testudata@LUA_5.4 5.4.6
198 luaL_tolstring@LUA_5.4 5.4.6
199 luaL_traceback@LUA_5.4 5.4.6
200 luaL_typeerror@LUA_5.4 5.4.6
201 luaL_unref@LUA_5.4 5.4.6
202 luaL_where@LUA_5.4 5.4.6
203 lua_absindex@LUA_5.4 5.4.6
204 lua_arith@LUA_5.4 5.4.6
205 lua_atpanic@LUA_5.4 5.4.6
206 lua_callk@LUA_5.4 5.4.6
207 lua_checkstack@LUA_5.4 5.4.6
208 lua_close@LUA_5.4 5.4.6
209 lua_compare@LUA_5.4 5.4.6
210 lua_concat@LUA_5.4 5.4.6
211 lua_copy@LUA_5.4 5.4.6
212 lua_createtable@LUA_5.4 5.4.6
213 lua_dump@LUA_5.4 5.4.6
214 lua_error@LUA_5.4 5.4.6
215 lua_gc@LUA_5.4 5.4.6
216 lua_getallocf@LUA_5.4 5.4.6
217 lua_getfield@LUA_5.4 5.4.6
218 lua_getglobal@LUA_5.4 5.4.6
219 lua_gethook@LUA_5.4 5.4.6
220 lua_gethookcount@LUA_5.4 5.4.6
221 lua_gethookmask@LUA_5.4 5.4.6
222 lua_geti@LUA_5.4 5.4.6
223 lua_getinfo@LUA_5.4 5.4.6
224 lua_getiuservalue@LUA_5.4 5.4.6
225 lua_getlocal@LUA_5.4 5.4.6
226 lua_getmetatable@LUA_5.4 5.4.6
227 lua_getstack@LUA_5.4 5.4.6
228 lua_gettable@LUA_5.4 5.4.6
229 lua_gettop@LUA_5.4 5.4.6
230 lua_getupvalue@LUA_5.4 5.4.6
231 lua_ident@LUA_5.4 5.4.6
232 lua_iscfunction@LUA_5.4 5.4.6
233 lua_isinteger@LUA_5.4 5.4.6
234 lua_isnumber@LUA_5.4 5.4.6
235 lua_isstring@LUA_5.4 5.4.6
236 lua_isuserdata@LUA_5.4 5.4.6
237 lua_isyieldable@LUA_5.4 5.4.6
238 lua_len@LUA_5.4 5.4.6
239 lua_load@LUA_5.4 5.4.6
240 lua_newstate@LUA_5.4 5.4.6
241 lua_newthread@LUA_5.4 5.4.6
242 lua_newuserdatauv@LUA_5.4 5.4.6
243 lua_next@LUA_5.4 5.4.6
244 lua_pcallk@LUA_5.4 5.4.6
245 lua_pushboolean@LUA_5.4 5.4.6
246 lua_pushcclosure@LUA_5.4 5.4.6
247 lua_pushfstring@LUA_5.4 5.4.6
248 lua_pushinteger@LUA_5.4 5.4.6
249 lua_pushlightuserdata@LUA_5.4 5.4.6
250 lua_pushlstring@LUA_5.4 5.4.6
251 lua_pushnil@LUA_5.4 5.4.6
252 lua_pushnumber@LUA_5.4 5.4.6
253 lua_pushstring@LUA_5.4 5.4.6
254 lua_pushthread@LUA_5.4 5.4.6
255 lua_pushvalue@LUA_5.4 5.4.6
256 lua_pushvfstring@LUA_5.4 5.4.6
257 lua_rawequal@LUA_5.4 5.4.6
258 lua_rawget@LUA_5.4 5.4.6
259 lua_rawgeti@LUA_5.4 5.4.6
260 lua_rawgetp@LUA_5.4 5.4.6
261 lua_rawlen@LUA_5.4 5.4.6
262 lua_rawset@LUA_5.4 5.4.6
263 lua_rawseti@LUA_5.4 5.4.6
264 lua_rawsetp@LUA_5.4 5.4.6
265 lua_resetthread@LUA_5.4 5.4.6
266 lua_resume@LUA_5.4 5.4.6
267 lua_rotate@LUA_5.4 5.4.6
268 lua_setallocf@LUA_5.4 5.4.6
269 lua_setfield@LUA_5.4 5.4.6
270 lua_setglobal@LUA_5.4 5.4.6
271 lua_sethook@LUA_5.4 5.4.6
272 lua_seti@LUA_5.4 5.4.6
273 lua_setiuservalue@LUA_5.4 5.4.6
274 lua_setlocal@LUA_5.4 5.4.6
275 lua_setmetatable@LUA_5.4 5.4.6
276 lua_settable@LUA_5.4 5.4.6
277 lua_settop@LUA_5.4 5.4.6
278 lua_setupvalue@LUA_5.4 5.4.6
279 lua_setwarnf@LUA_5.4 5.4.6
280 lua_status@LUA_5.4 5.4.6
281 lua_stringtonumber@LUA_5.4 5.4.6
282 lua_toboolean@LUA_5.4 5.4.6
283 lua_tocfunction@LUA_5.4 5.4.6
284 lua_toclose@LUA_5.4 5.4.6
285 lua_tointegerx@LUA_5.4 5.4.6
286 lua_tolstring@LUA_5.4 5.4.6
287 lua_tonumberx@LUA_5.4 5.4.6
288 lua_topointer@LUA_5.4 5.4.6
289 lua_tothread@LUA_5.4 5.4.6
290 lua_touserdata@LUA_5.4 5.4.6
291 lua_type@LUA_5.4 5.4.6
292 lua_typename@LUA_5.4 5.4.6
293 lua_upvalueid@LUA_5.4 5.4.6
294 lua_upvaluejoin@LUA_5.4 5.4.6
295 lua_version@LUA_5.4 5.4.6
296 lua_warning@LUA_5.4 5.4.6
297 lua_xmove@LUA_5.4 5.4.6
298 lua_yieldk@LUA_5.4 5.4.6
299 luaopen_base@LUA_5.4 5.4.6
300 luaopen_coroutine@LUA_5.4 5.4.6
301 luaopen_debug@LUA_5.4 5.4.6
302 luaopen_io@LUA_5.4 5.4.6
303 luaopen_math@LUA_5.4 5.4.6
304 luaopen_os@LUA_5.4 5.4.6
305 luaopen_package@LUA_5.4 5.4.6
306 luaopen_string@LUA_5.4 5.4.6
307 luaopen_table@LUA_5.4 5.4.6
308 luaopen_utf8@LUA_5.4 5.4.6

Subscribers

People subscribed via source and target branches

to all changes: