Code review comment for ~lvoytek/ubuntu/+source/libvirt:sapphire-rapids-and-libvirt-uri-jammy

Revision history for this message
Bryce Harrington (bryce) wrote :

This looks to be properly carrying the changes from https://code.launchpad.net/~lvoytek/ubuntu/+source/libvirt/+git/libvirt/+merge/455071 back to jammy, and the further support as mentioned. PPA builds properly, I didn't check autopkgtests but this type of change is unlikely to be adequately exercised by those tests. There is a quantity of patches here but they're principally all XML tweaks along with corresponding python and C code, all of which looks good on a quick visual inspection.

LGTM, +1

review: Approve

« Back to merge proposal