Code review comment for ~lvoytek/ubuntu/+source/libvirt:sapphire-rapids-and-libvirt-uri-lunar

Revision history for this message
Bryce Harrington (bryce) wrote :

The xen fix LGTM.

I don't have hardware for testing the Sapphire Rapids but see the PPA has been verified by someone who does. So that looks good as well. Fwiw, since you're listing this as one bullet point in the d/changelog, it'd be fine to add all the patches as a single git-ubuntu commit rather than broken out, esp. since they'll probably all drop together in a future merge, however that's all entirely personal preference.

So, overall LGTM, +1.

review: Approve

« Back to merge proposal