Code review comment for ~lvoytek/ubuntu/+source/caja-extensions:fix-l-param-jammy

Revision history for this message
Bryce Harrington (bryce) wrote :

Verified from the link mentioned in the bug header that -l is deprecated

    net:
    -l is not available for --long anymore

So, straightforward change, LGTM. The SRU text also looks good, although I wonder since there are several packages involved here, is there any possibility a user could get into a inconsistent situation if they have older versions of any of the components installed? I don't think you need to mention "Other issues with sharing may show up..." unless you have specific concerns; this is a bit hand-wavy so may lead to requests/pushback from SRU reviewers to clarify.

I try to think about the "Where problems could occur" section from the context of if someone upgrades to this version and then experiences some random regression, how they could rule out whether it's likely or not this update caused their problem. So for instance, you might say that the change modifies how nautilus interacts with samba, so any regression would be limited to behaviors around share creation when using samba. You might also mention that as mitigation to any regression, that a workaround would be to manually create shares from the CLI, as described in comment #2.

Let me know if you need me to sponsor the upload for this. (I've no idea if caja-extensions is included in the server packageset.)

review: Approve

« Back to merge proposal