Code review comment for ~lutostag/layer-snap:use_juju_proxy

Revision history for this message
Stuart Bishop (stub) wrote :

Do we actually want the configuration item?

I can't think of any situation where people set http_proxy but do not want it used to access the snap store (as opposed to apt_http_proxy, where that would be very wrong)

Unless we have actual use cases, I'd like the config option removed. We can add it later if needed, but I'd rather not have it polluting the config namespace of all charms using the layer if it isn't needed.

(and now I see this MP, perhaps the separate snap_proxy config item was a bad idea. Maybe we should deprecate that, if we can one day remove it without breaking actual deployments.)

review: Needs Fixing

« Back to merge proposal