Merge lp:~lutostag/gomaasapi/fix_nonce_generation into lp:gomaasapi

[Greg Lutostanski]

Use a much larger random for the nonce to prevent collisions. This uses a naive 16 byte random -> String rather than a real uuidgen because I didn't want to add the dep to another package.

Use a much larger random for the nonce to prevent collisions. This uses a naive 16 byte random -> String rather than a real uuidgen because I didn't want to add the dep to another package.

[Ian Booth (wallyworld)]

review: Approve

=== modified file 'oauth.go'
--- oauth.go	2013-02-05 13:25:01 +0000
+++ oauth.go	2014-08-20 22:02:46 +0000
@@ -6,7 +6,6 @@
 import (
 	"crypto/rand"
 	"fmt"
-	"math/big"
 	"net/http"
 	"net/url"
 	"strconv"
@@ -14,14 +13,14 @@
 	"time"
 )
 
-var nonceMax = big.NewInt(100000000)
-
+// Not a true uuidgen, but at least creates same length random
 func generateNonce() (string, error) {
-	randInt, err := rand.Int(rand.Reader, nonceMax)
+	randBytes := make([]byte, 16)
+	_, err := rand.Read(randBytes)
 	if err != nil {
 		return "", err
 	}
-	return strconv.Itoa(int(randInt.Int64())), nil
+	return fmt.Sprintf("%16x", randBytes), nil
 }
 
 func generateTimestamp() string {