Code review comment for lp:~luoyonggang/subvertpy/unittest-win32

On 03/12/2012 03:25 AM, Yonggang Luo wrote:
> 2012/3/12 Jelmer Vernooij<email address hidden>
>
>> Review: Needs Fixing
>>
>> Thanks.
>>
>> urllib.pathname2url will only return a single leading slash on UNIX, so
>> you'll need to keep the special casing specific to windows.
>> --
>>
>> https://code.launchpad.net/~luoyonggang/subvertpy/unittest-win32/+merge/96920
>> You are the owner of lp:~luoyonggang/subvertpy/unittest-win32.
>>
> can you be more specific? or just merge with modification...
> give me a path example.. is that the things like
> "file://%s" on unix?

urllib.pathname2url("/foo") just returns "/foo" on UNIX (and the URL
needs to be "file:///foo"), so you'll have to keep the existing if
statement for sys.platform in.

Cheers,

Jelmer