Code review comment for lp:~luoyonggang/subvertpy/unittest-win32

2012/3/11 Jelmer Vernooij <email address hidden>

> This is not a fix. It's a workaround that happens to work on your machine,
> and we don't even know why.
>
> For all we know it might break on other machines, for example machines on
> which TEMP uses a different case. It changes the default behavior for
> finding a location to store temporary files.
>
 I am already make sure it's only change the behavior on *Windows*. that's
I am familiar, and I can 100% sure that's the correct behavior, I know
that's a PYTHON bug, but we can work around it, because it's a bug across
python 2.x - python 3.2, so that's make sense to do that.
and at last, it's UNITTEST, the destination of UNITTEST is to test the
program. that's is, if the program is correct, then it's PASSED,
we should not show it's FAILED when it's was correct.
*+ if os.name == 'nt':
*+ self.test_dir = tempfile.mkdtemp(dir =
+ os.getenv("TEMP", None) or os.getenv("TMP", None))
+ else:
+ self.test_dir = tempfile.mkdtemp()

>
> If e.g. the svn libraries always lowercase the URLs on Windows, then we
> should make sure to call .lower() on our generated URL in subvertpy too
> when comparing.
> --
>
> https://code.launchpad.net/~luoyonggang/subvertpy/unittest-win32/+merge/96920
> You are the owner of lp:~luoyonggang/subvertpy/unittest-win32.
>

--
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo