Code review comment for lp:~luoyonggang/subvertpy/unittest-win32

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This is not a fix. It's a workaround that happens to work on your machine, and we don't even know why.

For all we know it might break on other machines, for example machines on which TEMP uses a different case. It changes the default behavior for finding a location to store temporary files.

If e.g. the svn libraries always lowercase the URLs on Windows, then we should make sure to call .lower() on our generated URL in subvertpy too when comparing.

« Back to merge proposal