Code review comment for lp:~luoyonggang/subvertpy/python3

Revision history for this message
Yonggang Luo (luoyonggang) wrote :

2012/3/11 Jelmer Vernooij <email address hidden>

> > 2012/3/11 Jelmer Vernooij <email address hidden>
> >
> > > > This is not ready for merge, I am request for *TEST *it:)...
> > > > Anyway, it's passed all tests except *three *test failed under
> Python 2.7
> > > I'm not sure I follow? Merge requests are meant to be used to request a
> > > branch to be merged into another.
> > >
> > > If you're trying to do something else with them, please at least
> *mention*
> > > what that is.
> > >
> > OK... well, I want to know is there any problem with unittest merge
> > request? I've got no response..
> What is a unittest merge request?
>
> > Or you have other ways to deal with package_data?
> I don't see how that's relevant in the python3 branch..
>
Python 3 is also contained this patch...
merge that first will get this branch be easier to merge.

>
> Cheers,
>
> Jelmer
> --
> https://code.launchpad.net/~luoyonggang/subvertpy/python3/+merge/96917
> You are the owner of lp:~luoyonggang/subvertpy/python3.
>

--
         此致

罗勇刚
Yours
    sincerely,
Yonggang Luo

« Back to merge proposal